-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: do not set AnnQuery when TopK = MaxUint32 #57307
Conversation
Signed-off-by: Lloyd-Pottiger <[email protected]>
Hi @Lloyd-Pottiger. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #57307 +/- ##
================================================
+ Coverage 72.9496% 75.8135% +2.8639%
================================================
Files 1667 1677 +10
Lines 460833 492288 +31455
================================================
+ Hits 336176 373221 +37045
+ Misses 103971 98896 -5075
+ Partials 20686 20171 -515
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: breezewish, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
@Lloyd-Pottiger: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: ref #54245
Problem Summary:
What changed and how does it work?
When
p.AnnIndexExtra.PushDownQueryInfo.TopK == math.MaxUint32
, there is no need to setAnnQuery
inTableScan
/PartitionTableScan
, since it means do not use vector index.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.