Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: do not set AnnQuery when TopK = MaxUint32 #57307

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented Nov 12, 2024

What problem does this PR solve?

Issue Number: ref #54245

Problem Summary:

What changed and how does it work?

When p.AnnIndexExtra.PushDownQueryInfo.TopK == math.MaxUint32, there is no need to set AnnQuery in TableScan/PartitionTableScan, since it means do not use vector index.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/planner SIG: Planner labels Nov 12, 2024
Copy link

tiprow bot commented Nov 12, 2024

Hi @Lloyd-Pottiger. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.8135%. Comparing base (3047328) to head (b4d3f11).
Report is 159 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57307        +/-   ##
================================================
+ Coverage   72.9496%   75.8135%   +2.8639%     
================================================
  Files          1667       1677        +10     
  Lines        460833     492288     +31455     
================================================
+ Hits         336176     373221     +37045     
+ Misses       103971      98896      -5075     
+ Partials      20686      20171       -515     
Flag Coverage Δ
integration 45.7027% <0.0000%> (?)
unit 74.8871% <0.0000%> (+2.5441%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 47.9664% <ø> (+2.8926%) ⬆️

@Lloyd-Pottiger
Copy link
Contributor Author

/cc @winoros @hawkingrei @breezewish

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 12, 2024
Copy link

ti-chi-bot bot commented Nov 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: breezewish, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 29, 2024
Copy link

ti-chi-bot bot commented Nov 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-12 09:43:51.521928463 +0000 UTC m=+349393.712797461: ☑️ agreed by breezewish.
  • 2024-11-29 03:29:44.824112294 +0000 UTC m=+779972.443766800: ☑️ agreed by winoros.

Copy link

tiprow bot commented Nov 29, 2024

@Lloyd-Pottiger: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow b4d3f11 link true /test fast_test_tiprow
tidb_parser_test b4d3f11 link true /test tidb_parser_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit cbf34b0 into pingcap:master Nov 29, 2024
22 of 24 checks passed
@Lloyd-Pottiger Lloyd-Pottiger deleted the fix-ann branch November 29, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants