owner: refactor logger and err handling in campaign loop #57705
Conversation
ti-chi-bot
bot
added
release-note-none
|
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| @@ -456,26 +452,17 @@ func (m *ownerManager) refreshSession(retryCnt, ttl int) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (m *ownerManager) revokeSession(leaseID clientv3.LeaseID) { | |||
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #57705 +/- ##
================================================
+ Coverage 72.8318% 73.8879% +1.0560%
================================================
Files 1677 1677
Lines 463944 468557 +4613
================================================
+ Hits 337899 346207 +8308
+ Misses 105169 101674 -3495
+ Partials 20876 20676 -200
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| return &ownerManager{ | ||
| etcdCli: etcdCli, | ||
| id: id, | ||
| key: key, | ||
| ctx: ctx, | ||
| prompt: prompt, | ||
| logPrefix: logPrefix, | ||
| logCtx: logutil.WithKeyValue(context.Background(), "owner info", logPrefix), | ||
| logger: logutil.BgLogger().With(zap.String("key", key), zap.String("id", id)), |
There was a problem hiding this comment.
in the old log, prompt is also printed.
There was a problem hiding this comment.
key contains enough info, prompt is redundant
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
approved
lgtm
and removed
needs-1-more-lgtm
What problem does this PR solve?
Issue Number: ref #57275
Problem Summary:
What changed and how does it work?
ownerManagerstruct: ReplacedlogPrefixandlogCtxfields with aloggerfield of type*zap.Logger.loggerfield instead of the previouslogPrefixandlogCtx.campaignAndWatchfunction: Refactored part of thecampaignLoopfunction into a newcampaignAndWatchfunction for better readability and separation of concerns.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.