ddl: fix the primary key in index is not in restored format (#53118) #57999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot
added
release-note
13 tasks
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
size/L
|
|
ti-chi-bot
bot
added
size/M
CbcWestwolf
force-pushed
the
cherry-pick-53118-to-release-7.1
branch
from
9c9bf1b to
793e2e0
Compare
|
/retest |
CbcWestwolf
force-pushed
the
cherry-pick-53118-to-release-7.1
branch
from
793e2e0 to
783f9ed
Compare
CbcWestwolf
approved these changes
Dec 5, 2024
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #57999 +/- ##
================================================
Coverage ? 73.4680%
================================================
Files ? 1213
Lines ? 382071
Branches ? 0
================================================
Hits ? 280700
Misses ? 83447
Partials ? 17924 |
ti-chi-bot
bot
added
cherry-pick-approved
|
/approve |
fzzf678
approved these changes
Dec 6, 2024
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, CbcWestwolf, fzzf678 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #53118
What problem does this PR solve?
Issue Number: close #58036 #52510
Problem Summary:
when fast reorg and new collation are enabled, index backfilling only considers the need to restore the index columns, but ignores the primary key columns. The result is that the primary key in the index is not restored.
What changed and how does it work?
When considering the need to restore an index, check both the index columns and the primary key columns.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.