Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: fix flaky test TestSyncLoadOnObjectWhichCanNotFoundInStorage #58164

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Dec 11, 2024

What problem does this PR solve?

Issue Number: close #58162

Problem Summary:

What changed and how does it work?

sync load is running on the background. so we need to create the checkpoint which wait for the sync load's completing working. then we can check the result.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Dec 11, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.8534%. Comparing base (2a1f646) to head (cf13c82).
Report is 3 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58164        +/-   ##
================================================
+ Coverage   73.2116%   73.8534%   +0.6418%     
================================================
  Files          1675       1705        +30     
  Lines        461921     470074      +8153     
================================================
+ Hits         338180     347166      +8986     
+ Misses       102981     101471      -1510     
- Partials      20760      21437       +677     
Flag Coverage Δ
integration 45.9662% <ø> (?)
unit 72.3238% <ø> (-0.0211%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.9998% <ø> (+0.0060%) ⬆️

Copy link

ti-chi-bot bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 11, 2024
Copy link

ti-chi-bot bot commented Dec 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-11 07:30:53.652392497 +0000 UTC m=+423643.741195039: ☑️ agreed by AilinKid.
  • 2024-12-11 07:53:44.413170276 +0000 UTC m=+425014.501972816: ☑️ agreed by lance6716.

@hawkingrei
Copy link
Member Author

/retest

Copy link

tiprow bot commented Dec 11, 2024

@hawkingrei: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow cf13c82 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit 4ec2b23 into pingcap:master Dec 11, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestSyncLoadOnObjectWhichCanNotFoundInStorage errors like nil pointer dereference
3 participants