Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: refactor names from VectorHelper to VSInfo #58192

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

breezewish
Copy link
Member

What problem does this PR solve?

Issue Number: ref #54245

Problem Summary:

What changed and how does it work?

Refactor names to reduce confusion.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 12, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 12, 2024
@AilinKid AilinKid changed the title expression: Refactor names expression: refactor names from VectorHelper to VSInfo Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.7203%. Comparing base (e54cc5b) to head (49cec6e).
Report is 59 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58192        +/-   ##
================================================
+ Coverage   73.1811%   73.7203%   +0.5391%     
================================================
  Files          1676       1676                
  Lines        462078     462216       +138     
================================================
+ Hits         338154     340747      +2593     
+ Misses       103155     100746      -2409     
+ Partials      20769      20723        -46     
Flag Coverage Δ
integration 43.2099% <42.8571%> (?)
unit 72.4270% <100.0000%> (+0.1212%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 46.0058% <ø> (+0.0240%) ⬆️

Copy link

ti-chi-bot bot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 12, 2024
Copy link

ti-chi-bot bot commented Dec 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-12 04:26:39.353993929 +0000 UTC m=+498989.442796472: ☑️ agreed by AilinKid.
  • 2024-12-12 05:54:21.269844301 +0000 UTC m=+504251.358646844: ☑️ agreed by XuHuaiyu.

@ti-chi-bot ti-chi-bot bot merged commit 4e6468d into pingcap:master Dec 12, 2024
23 checks passed
@breezewish breezewish deleted the wenxuan/name-refine branch December 12, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants