Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

execdetails: reduce mem allocs on RecordOneCopTask #58235

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

zyguan
Copy link
Contributor

@zyguan zyguan commented Dec 13, 2024

What problem does this PR solve?

Issue Number: ref #56649

Problem Summary: RecordOneCopTask constructs a new basicCopRuntimeStats and merge it, which is inefficient (introduce extra mem allocs).

What changed and how does it work?

Let it merge ExecutorExecutionSummary directly.

baseline:
2024-12-13_101111

this PR:
2024-12-13_101140

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 13, 2024
Copy link

tiprow bot commented Dec 13, 2024

Hi @zyguan. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: zyguan <[email protected]>
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 92.75362% with 5 lines in your changes missing coverage. Please review.

Project coverage is 73.5944%. Comparing base (68ac9ec) to head (6873227).
Report is 71 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58235        +/-   ##
================================================
+ Coverage   73.1841%   73.5944%   +0.4102%     
================================================
  Files          1675       1676         +1     
  Lines        461917     464875      +2958     
================================================
+ Hits         338050     342122      +4072     
+ Misses       103127     101921      -1206     
- Partials      20740      20832        +92     
Flag Coverage Δ
integration 43.1976% <17.3913%> (?)
unit 72.3232% <92.7536%> (+0.0085%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.9758% <ø> (+0.0150%) ⬆️

@zyguan
Copy link
Contributor Author

zyguan commented Dec 13, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Dec 13, 2024
@zyguan
Copy link
Contributor Author

zyguan commented Dec 13, 2024

/retest

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 13, 2024
Copy link

ti-chi-bot bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, crazycs520

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cfzjywxk,crazycs520]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 17, 2024
Copy link

ti-chi-bot bot commented Dec 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-13 09:18:57.016463154 +0000 UTC m=+602927.105265692: ☑️ agreed by crazycs520.
  • 2024-12-17 08:47:18.36093926 +0000 UTC m=+946628.449741803: ☑️ agreed by cfzjywxk.

@ti-chi-bot ti-chi-bot bot merged commit 7b051c8 into pingcap:master Dec 17, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants