Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

var: enable pd_enable_follower_handle_region as default #58385

Merged
merged 5 commits into from
Jan 8, 2025
Merged

var: enable pd_enable_follower_handle_region as default #58385

merged 5 commits into from
Jan 8, 2025

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Dec 18, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #58384

Problem Summary:

What changed and how does it work?

as title

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.
image

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Enable `pd_enable_follower_handle_region` as default; Add a panel `Stale Region from PD` to show the stale region quantity.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 18, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 26, 2024
@okJiang
Copy link
Member Author

okJiang commented Dec 26, 2024

/retest

@codecov Codecov
Copy link

codecov bot commented Dec 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.6607%. Comparing base (8e1a47d) to head (23f0743).
Report is 64 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #58385        +/-   ##
================================================
+ Coverage   73.5154%   74.6607%   +1.1452%     
================================================
  Files          1681       1682         +1     
  Lines        464479     486569     +22090     
================================================
+ Hits         341464     363276     +21812     
+ Misses       102179     102046       -133     
- Partials      20836      21247       +411
Flag Coverage Δ
integration 44.2926% <ø> (?)
unit 73.4385% <ø> (+1.1741%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.0074% <ø> (-0.7790%) ⬇️

@okJiang
Copy link
Member Author

okJiang commented Dec 27, 2024

/cc @rleungx @JmPotato

@ti-chi-bot ti-chi-bot bot requested review from JmPotato and rleungx December 27, 2024 08:13
@okJiang
Copy link
Member Author

okJiang commented Dec 27, 2024

/retest

@okJiang
update title
23f0743 
Signed-off-by: okJiang <[email protected]>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 7, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 7, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 7, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-07 09:16:43.935206436 +0000 UTC m=+258747.224038127: ☑️ agreed by YuJuncen.
  • 2025-01-07 09:22:52.957121876 +0000 UTC m=+259116.245953581: ☑️ agreed by rleungx.

@tiprow tiprow
Copy link

tiprow bot commented Jan 7, 2025

@okJiang: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 23f0743 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

yudongusa
yudongusa approved these changes Jan 8, 2025
View reviewed changes
Copy link

@yudongusa yudongusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remember to update the TiDB document on this.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rleungx, yudongusa, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 8, 2025
@ti-chi-bot ti-chi-bot bot merged commit 6c9ee36 into pingcap:master Jan 8, 2025
23 of 24 checks passed
@okJiang okJiang deleted the enable-pd-active-follower branch January 8, 2025 06:26
breezewish added a commit that referenced this pull request Jan 8, 2025
@breezewish
Merge commit '510d0037b18f258f505abc6cf13a8128563e9359' into wenxuan/…
3f825ba 
…long-vector

* commit '510d0037b18f258f505abc6cf13a8128563e9359':
  *: upgrade pd client to make sure tso client initiate successfully (#58752)
  ttl, test: scale TTL workers during the fault tests (#58750)
  planner: improve warning messages for unsupported HASH_JOIN hints (#58646)
  planner: prealloc the slices in the SplitCorColAccessCondFromFilters (#58785)
  ddl: supports non-unique global index (#58678)
  util/stmtsummary: add the network traffic related fields (#58101)
  var: enable `pd_enable_follower_handle_region` as default (#58385)
  statistics: refactor stats meta handling to use DeltaUpdate for multi-table support (#58657)
  parser: move 'model' to 'ast' pkg (#58704)
  statistics: add recover to protect background task (#58739)
  disttask: cancel subtask context if scheduled away (#58615)
  *: don't handle live updates of column size (#58596)
  *: fix a bug for default_authentication_plugin (2) (#58723)
  dupdetect: gRPC cancel should trigger retry (#58542)
  *: fix a bug for default_authentication_plugin (#57391)
  distsql: Fix backoff execution info inaccurate issue (#58707)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yudongusa yudongusa yudongusa approved these changes

@YuJuncen YuJuncen YuJuncen approved these changes

@rleungx rleungx rleungx approved these changes

@JmPotato JmPotato Awaiting requested review from JmPotato

Assignees
No one assigned
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set pd_enable_follower_handle_region as default
4 participants
@okJiang @rleungx @YuJuncen @yudongusa