ddl: implement backoff strategy for async event notification in tests #58386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance the asyncNotifyEvent function to include a backoff mechanism when sending events to the channel during unit tests. This prevents indefinite blocking on a full channel by attempting to send the event multiple times before giving up, while also logging a warning if the notification fails. Signed-off-by: Rustin170506 <[email protected]>
ti-chi-bot
bot
added
do-not-merge/needs-triage-completed
release-note-none
Rustin170506
commented
Dec 18, 2024
lance6716
approved these changes
Dec 18, 2024
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
|
/hold wait for addressing comment |
ti-chi-bot
bot
added
the
do-not-merge/hold
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #58386 +/- ##
================================================
+ Coverage 73.1936% 75.2163% +2.0227%
================================================
Files 1681 1726 +45
Lines 463050 472913 +9863
================================================
+ Hits 338923 355708 +16785
+ Misses 103344 95076 -8268
- Partials 20783 22129 +1346
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tiancaiamao
approved these changes
Dec 18, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, tiancaiamao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/test all |
Tested with the case from the issue. 
|
|
/unhold |
ti-chi-bot
bot
removed
the
do-not-merge/hold
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
ti-chi-bot
bot
added
do-not-merge/needs-triage-completed
and removed
do-not-merge/needs-triage-completed
labels
|
/retest |
Rustin170506
added a commit
to ti-chi-bot/tidb
that referenced
this pull request
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #58344 close #58421
Problem Summary:
What changed and how does it work?
Enhance the asyncNotifyEvent function to include a backoff mechanism when sending events to the channel during unit tests. This prevents indefinite blocking on a full channel by attempting to send the event multiple times before giving up, while also logging a warning if the notification fails.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.