Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importinto: use same type context flag setting as insert #58606

Merged
merged 8 commits into from
Dec 31, 2024

Conversation

D3Hunter
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #58443

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

same step as in the issue

mysql> create table t(a double);
Query OK, 0 rows affected (0.06 sec)

mysql> create table s(x varchar(20));
Query OK, 0 rows affected (0.04 sec)

mysql> insert into s values('1e309abc');
Query OK, 1 row affected (0.01 sec)

mysql> alter table s set tiflash replica 1;
Query OK, 0 rows affected (0.06 sec)

mysql> set tidb_enforce_mpp=1;
Query OK, 0 rows affected (0.00 sec)

mysql> set sql_mode='';
Query OK, 0 rows affected (0.00 sec)

mysql> insert into t select cast(x as double) from s;
Query OK, 1 row affected, 2 warnings (0.01 sec)
Records: 1  Duplicates: 0  Warnings: 2

mysql> select * from t;
+------------------------+
| a                      |
+------------------------+
| 1.7976931348623157e308 |
+------------------------+
1 row in set (0.00 sec)

mysql> truncate t;
Query OK, 0 rows affected (0.04 sec)

mysql> import into t from select cast(x as double) from s;
Query OK, 1 row affected, 2 warnings (0.25 sec)
Records: 1, ID: ac38d72e-d657-4b2a-9ec8-1b762c37a3a5

mysql> select * from t;
+------------------------+
| a                      |
+------------------------+
| 1.7976931348623157e308 |
+------------------------+
1 row in set (0.00 sec)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 30, 2024
Copy link

tiprow bot commented Dec 30, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.5340%. Comparing base (42d4fae) to head (0fae65d).
Report is 23 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58606        +/-   ##
================================================
+ Coverage   73.1093%   73.5340%   +0.4247%     
================================================
  Files          1676       1676                
  Lines        463354     463403        +49     
================================================
+ Hits         338755     340759      +2004     
+ Misses       103788     101834      -1954     
+ Partials      20811      20810         -1     
Flag Coverage Δ
integration 43.0342% <100.0000%> (?)
unit 72.3010% <100.0000%> (-0.0052%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.8233% <ø> (+0.0209%) ⬆️

@D3Hunter
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Dec 30, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 30, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 31, 2024
@D3Hunter
Copy link
Contributor Author

the undefined: domain.BindDomain is caused by #58550 deleted the api

@D3Hunter
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Dec 31, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 31, 2024
Copy link

ti-chi-bot bot commented Dec 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcwangchao, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lcwangchao,wjhuang2016]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 31, 2024
Copy link

ti-chi-bot bot commented Dec 31, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-31 05:06:36.507116336 +0000 UTC m=+413331.863120876: ☑️ agreed by lcwangchao.
  • 2024-12-31 06:59:43.488986913 +0000 UTC m=+420118.844991482: ☑️ agreed by wjhuang2016.

@ti-chi-bot ti-chi-bot bot merged commit 284a3ee into pingcap:master Dec 31, 2024
23 of 24 checks passed
@D3Hunter D3Hunter deleted the fix-importintoflag branch December 31, 2024 07:08
Copy link

ti-chi-bot bot commented Jan 5, 2025

@D3Hunter: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/build 6fbcec4 link true /test build

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import into ... from select does not comply with the current SQL mode
3 participants