Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: Fix vector not truncated after CBO #58809

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

breezewish
Copy link
Member

@breezewish breezewish commented Jan 8, 2025

What problem does this PR solve?

Issue Number: Close #58837

Problem Summary:

What changed and how does it work?

After CBO is introduced, vector is not truncated in explain. This is what it looks like now without this PR:

image

Upstream PR: https://github.com/tidbcloud/tidb-cse/pull/1416

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/planner SIG: Planner labels Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.9975%. Comparing base (2a3542c) to head (3e2185f).
Report is 14 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58809        +/-   ##
================================================
+ Coverage   73.0827%   73.9975%   +0.9148%     
================================================
  Files          1676       1677         +1     
  Lines        463747     467987      +4240     
================================================
+ Hits         338919     346299      +7380     
+ Misses       103979     100965      -3014     
+ Partials      20849      20723       -126     
Flag Coverage Δ
integration 43.5976% <0.0000%> (?)
unit 72.8047% <100.0000%> (+0.5321%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.7389% <ø> (+0.0059%) ⬆️

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Jan 9, 2025
Copy link

ti-chi-bot bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: winoros, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 9, 2025
Copy link

ti-chi-bot bot commented Jan 9, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-09 04:40:52.156548239 +0000 UTC m=+414995.445379944: ☑️ agreed by XuHuaiyu.
  • 2025-01-09 18:13:18.725620856 +0000 UTC m=+463742.014452559: ☑️ agreed by winoros.

@ti-chi-bot ti-chi-bot bot merged commit d9dc3f4 into pingcap:master Jan 9, 2025
24 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #58844.

@breezewish breezewish deleted the wenxuan/vector-truncate branch January 10, 2025 00:44
ti-chi-bot bot pushed a commit that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

planner: Vector is not truncated in EXPLAIN ANALYZE
4 participants