-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: Fix vector index for high dimensional vectors (#58717) #58835
ddl: Fix vector index for high dimensional vectors (#58717) #58835
Conversation
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #58835 +/- ##
================================================
Coverage ? 57.0574%
================================================
Files ? 1770
Lines ? 627696
Branches ? 0
================================================
Hits ? 358147
Misses ? 245426
Partials ? 24123
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-unit-test-ddlv1 |
@breezewish: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an automated cherry-pick of #58717
What problem does this PR solve?
Issue Number: Close #58836
Problem Summary:
What changed and how does it work?
Fix Txn: KeyTooLong error when using vector index. It is caused by TiDB writes not only vector data but also vector keys, but TiDB shouldn't, as vector indexes are TiFlash local indexes and there is no need to write vector keys.
In this PR, the vector_long cluster integration test is just using the same test case as TestVectorLong unit test, simply run over the whole cluster to ensure everything works.
This is a cherry-pick of upstream PR: https://github.com/tidbcloud/tidb-cse/pull/1464
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.