Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: Fix vector index for high dimensional vectors (#58717) #58835

Merged

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jan 9, 2025

This is an automated cherry-pick of #58717

What problem does this PR solve?

Issue Number: Close #58836

Problem Summary:

What changed and how does it work?

Fix Txn: KeyTooLong error when using vector index. It is caused by TiDB writes not only vector data but also vector keys, but TiDB shouldn't, as vector indexes are TiFlash local indexes and there is no need to write vector keys.

In this PR, the vector_long cluster integration test is just using the same test case as TestVectorLong unit test, simply run over the whole cluster to ensure everything works.

This is a cherry-pick of upstream PR: https://github.com/tidbcloud/tidb-cse/pull/1464

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@587a810). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #58835   +/-   ##
================================================
  Coverage               ?   57.0574%           
================================================
  Files                  ?       1770           
  Lines                  ?     627696           
  Branches               ?          0           
================================================
  Hits                   ?     358147           
  Misses                 ?     245426           
  Partials               ?      24123           
Flag Coverage Δ
integration 36.9267% <10.5263%> (?)
unit 72.7465% <78.9473%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8711% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.2966% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 9, 2025
Copy link

ti-chi-bot bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 10, 2025
Copy link

ti-chi-bot bot commented Jan 10, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-09 11:44:00.250337406 +0000 UTC m=+440383.539169123: ☑️ agreed by tangenta.
  • 2025-01-10 02:20:50.726547313 +0000 UTC m=+492994.015379015: ☑️ agreed by XuHuaiyu.

@breezewish
Copy link
Member

/test pull-unit-test-ddlv1

Copy link

tiprow bot commented Jan 10, 2025

@breezewish: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-unit-test-ddlv1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 0005334 into pingcap:release-8.5 Jan 10, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants