statistics: remove dead code (#58412)

[ti-chi-bot]

This is an automated cherry-pick of #58412

Signed-off-by: Rustin170506 [email protected]

What problem does this PR solve?

Issue Number: ref #57804

Problem Summary:

What changed and how does it work?

In this PR, I removed the dead code. The stats loading for the PK, as shown, has never been executed, so it is safe to remove.

Some background:

1. statistics: fix PK column TopN not loading when init stats #37552 This PR tried to load it correctly.
2. statistics: fix wrong behavior for primary key' non-lite init stats #53298 This PR decided to remove it at all.
3. Another fix based on the previous PR: *: not load unnecessay data during the non-lite-init-stats #53399
4. Another full rewrite: statistics: correct behavior of non-lite InitStats and stats sync load of no stats column #57803

So we just forgot to delete it.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zhaoxinyu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
idc-jenkins-ci-tidb/build	927c944	link	true	/test build
idc-jenkins-ci-tidb/unit-test	927c944	link	true	/test unit-test
idc-jenkins-ci-tidb/check_dev	927c944	link	true	/test check-dev

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[Rustin170506]

I don't what is going on with the bot. So I am going to close it. We don't need to cherry-pick it to 6.5.