Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: push down truncate to tiflash #59318

Merged
merged 4 commits into from
Feb 12, 2025

Conversation

guo-shaoge
Copy link
Collaborator

@guo-shaoge guo-shaoge commented Feb 7, 2025

What problem does this PR solve?

Issue Number: close #59317

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

expression: push down truncate to tiflash

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 7, 2025
Signed-off-by: guo-shaoge <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.1168%. Comparing base (aa21818) to head (171dcca).
Report is 131 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #59318        +/-   ##
================================================
- Coverage   73.1282%   73.1168%   -0.0114%     
================================================
  Files          1680       1692        +12     
  Lines        464584     489236     +24652     
================================================
+ Hits         339742     357714     +17972     
- Misses       103978     109951      +5973     
- Partials      20864      21571       +707     
Flag Coverage Δ
integration 42.9627% <100.0000%> (?)
unit 72.3341% <100.0000%> (+0.0214%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 42.7689% <ø> (-2.6446%) ⬇️

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 8, 2025
Signed-off-by: guo-shaoge <[email protected]>
Signed-off-by: guo-shaoge <[email protected]>
Copy link

tiprow bot commented Feb 12, 2025

@guo-shaoge: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tidb_parser_test 171dcca link true /test tidb_parser_test
fast_test_tiprow 171dcca link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 12, 2025
Copy link

ti-chi-bot bot commented Feb 12, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-08 03:13:08.456912756 +0000 UTC m=+67030.853134819: ☑️ agreed by zimulala.
  • 2025-02-12 02:31:53.952898866 +0000 UTC m=+410156.349120927: ☑️ agreed by wshwsh12.

@guo-shaoge guo-shaoge removed the request for review from xzhangxian1008 February 12, 2025 08:50
Copy link

ti-chi-bot bot commented Feb 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wshwsh12, XuHuaiyu, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 12, 2025
@ti-chi-bot ti-chi-bot bot merged commit 453ccd7 into pingcap:master Feb 12, 2025
22 of 24 checks passed
@guo-shaoge guo-shaoge deleted the pushdown_tiflash_truncate branch February 12, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support push down truncate to tiflash
4 participants