Fix cast int as decimal #7795
Closed
Fix cast int as decimal #7795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
zz-jason
reviewed
Sep 27, 2018
| @@ -227,6 +227,9 @@ func (c *castAsDecimalFunctionClass) getFunction(ctx sessionctx.Context, args [] | |||
| } else { | |||
| argTp = args[0].GetType().EvalType() | |||
| } | |||
| if mysql.HasUnsignedFlag(args[0].GetType().Flag) { | |||
There was a problem hiding this comment.
The result flag doesn't contain the unsigned flag even if the input is an unsigned integer:
drop table if exists t;
create table t(a bigint unsigned);
insert into t values(pow(2, 63));In MySQL
MySQL(localhost:3306) > select cast(a as decimal(65,0)) from t;
Field 1: `cast(a as decimal(65,0))`
Catalog: `def`
Database: ``
Table: ``
Org_table: ``
Type: NEWDECIMAL
Collation: binary (63)
Length: 66
Max_length: 19
Decimals: 0
Flags: BINARY NUM
+--------------------------+
| cast(a as decimal(65,0)) |
+--------------------------+
| 9223372036854775808 |
+--------------------------+
1 row in set (0.00 sec)
|
@AndrewDi Feel free to reopen it. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
to fix #7778
What is changed and how it works?
change cast function init, if arg is unsigned, set cast function to unsigned, so that we can keep function return keep unsigned.
Check List
Tests
Code changes
Side effects
Related changes