stats: fix converting duration to timestamp #8174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this affect the release-2.1? |
|
@shenli Yes, I will cherry-pick it when this is merged. |
zz-jason
reviewed
Nov 5, 2018
statistics/handle.go
Outdated
| @@ -109,6 +109,11 @@ func (h *Handle) GetQueryFeedback() []*QueryFeedback { | |||
| return h.feedback | |||
| } | |||
|
|
|||
| // DurationToTS converts duration to timestamp. | |||
| func DurationToTS(d time.Duration) uint64 { | |||
| return oracle.ComposeTS(int64(d)/int64(time.Millisecond), 0) | |||
There was a problem hiding this comment.
how about:
d.Nanoseconds()/int64(time.Millisecond)
zimulala
added
status/LGT2
|
/run-all-tests |
alivxxx
added a commit
to alivxxx/tidb
that referenced
this pull request
Nov 5, 2018
alivxxx
added a commit
to alivxxx/tidb
that referenced
this pull request
Nov 5, 2018
zz-jason
pushed a commit
that referenced
this pull request
Nov 5, 2018
ngaut
pushed a commit
that referenced
this pull request
Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The deleted stats is not removed for a long time.
Fix #8115
What is changed and how it works?
We will delete the stats that have been deleted in 10 stats-lease ago. But when converting the stats lease to timestamp, which is the version info used in stats, we forgot to divide the million second unit, thus resulting in long stale time.
Check List
Tests
Code changes
Side effects
Related changes
PTAL @zz-jason @winoros @lzmhhh123