-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: support index nested loop hash join #8661
Changes from 63 commits
3ddc5cb
25d22fb
1329c93
0e75d4f
3f07d74
2383635
fede034
c3d36f6
0a5a602
0a36649
4ddcf80
e3277f4
9e3d3fe
6a579e1
62e6e22
ce9cb2d
a928cc2
74b7c1a
e1de17d
4dc605d
059b30b
916a384
88784fa
f3dee6d
18e4de9
770bd38
ecae4af
bea13ab
187fae7
4a13576
9eef4e3
007a11a
ef825e7
b9b9f5c
f12d573
000d74d
c2c30e6
f6af1cd
78d216a
54c81b5
98ad68a
a7fef3f
f1c3977
581b697
e28987a
c30504d
eb0b643
c1f9a71
d4ac7e7
8c92cd7
fad84f4
a79975f
f267865
5a25f27
3f7682c
b4a4f08
043dded
22e7215
e2f2b06
afde839
fd8c6ad
3ceeb1e
c05a2f2
041d625
7b642d4
099e802
e21e18e
841ce18
4028a91
d266812
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1803,7 +1803,10 @@ func (b *executorBuilder) buildIndexLookUpJoin(v *plannercore.PhysicalIndexJoin) | |
e.innerCtx.keyCols = innerKeyCols | ||
e.joinResult = newFirstChunk(e) | ||
executorCounterIndexLookUpJoin.Inc() | ||
return e | ||
if v.KeepOuterOrder { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need to modify the cost model of index join when There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, we need~ |
||
return e | ||
} | ||
return &IndexNestedLoopHashJoin{IndexLookUpJoin: *e} | ||
} | ||
|
||
// containsLimit tests if the execs contains Limit because we do not know whether `Limit` has consumed all of its' source, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems the behavior when
v.KeepOuterOrder
is not tested?