-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: tiny update CONTRIBUTING.md #8814
Conversation
PTAL @shenli |
@lilin90 PTAL |
/run-all-tests |
/run-unit-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PTAL @shenli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #8814 +/- ##
==========================================
+ Coverage 67.24% 67.25% +0.01%
==========================================
Files 371 371
Lines 75972 75972
==========================================
+ Hits 51086 51094 +8
+ Misses 20372 20367 -5
+ Partials 4514 4511 -3
Continue to review full report at Codecov.
|
What problem does this PR solve?
Review CONTRIBUTING.md, tiny update.
What is changed and how it works?
After we migrate to Go module, the Makefile still there and some tools depends on GOPATH.
So we haven't get rid of GOPATH totally.
Check List
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)