Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: tiny update CONTRIBUTING.md #8814

Merged
merged 4 commits into from
Jan 14, 2019

Conversation

tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Dec 25, 2018

What problem does this PR solve?

Review CONTRIBUTING.md, tiny update.

What is changed and how it works?

After we migrate to Go module, the Makefile still there and some tools depends on GOPATH.
So we haven't get rid of GOPATH totally.

Check List

  • No code

This change is Reviewable

@tiancaiamao
Copy link
Contributor Author

PTAL @shenli

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@shenli
Copy link
Member

shenli commented Dec 26, 2018

@lilin90 PTAL

CONTRIBUTING.md Outdated Show resolved Hide resolved
@tiancaiamao
Copy link
Contributor Author

/run-all-tests

@tiancaiamao
Copy link
Contributor Author

/run-unit-test

@tiancaiamao
Copy link
Contributor Author

PTAL @shenli @lilin90

Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao
Copy link
Contributor Author

PTAL @shenli

2 similar comments
@tiancaiamao
Copy link
Contributor Author

PTAL @shenli

@tiancaiamao
Copy link
Contributor Author

PTAL @shenli

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 7, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 14, 2019
@codecov-io
Copy link

Codecov Report

Merging #8814 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8814      +/-   ##
==========================================
+ Coverage   67.24%   67.25%   +0.01%     
==========================================
  Files         371      371              
  Lines       75972    75972              
==========================================
+ Hits        51086    51094       +8     
+ Misses      20372    20367       -5     
+ Partials     4514     4511       -3
Impacted Files Coverage Δ
executor/join.go 78.44% <0%> (+0.51%) ⬆️
ddl/delete_range.go 74.28% <0%> (+1.71%) ⬆️
ddl/session_pool.go 93.1% <0%> (+10.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b98ad6...193c2bc. Read the comment docs.

@zz-jason zz-jason merged commit 53707ce into pingcap:master Jan 14, 2019
@tiancaiamao tiancaiamao deleted the update-contributing branch March 24, 2020 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/docs status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants