planner: tidy code more go style #9845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Golang will auto init the variable. We do not need to it. warning: should drop = nil from declaration of var authErr; it is the zero value (golint) Signed-off-by: Keyi Xie <[email protected]>
|
/run-all-tests |
|
LGTM |
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #9845 +/- ##
================================================
- Coverage 67.1592% 67.1579% -0.0013%
================================================
Files 381 381
Lines 80056 80056
================================================
- Hits 53765 53764 -1
Misses 21500 21500
- Partials 4791 4792 +1 |
ngaut
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Golang will auto-init the variable.
We do not need it.
warning: should drop = nil from the declaration of var authErr; it is the zero value (golint)Signed-off-by: Keyi Xie [email protected]
What problem does this PR solve?
Make the code more like go style.
What is changed and how it works?
Remove useless init.
Check List
Tests