executor: fix group_concat for cases like group_concat(123,null) #9921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuHuaiyu
force-pushed
the
fix_group_concat
branch
from
df69548 to
db00ce0
Compare
Codecov Report
@@ Coverage Diff @@
## master #9921 +/- ##
================================================
+ Coverage 77.2162% 77.2346% +0.0183%
================================================
Files 405 405
Lines 81668 81668
================================================
+ Hits 63061 63076 +15
- Misses 13911 13919 +8
+ Partials 4696 4673 -23 |
eurekaka
added
status/LGT2
|
/run-all-tests |
eurekaka
previously approved these changes
Mar 28, 2019
zz-jason
reviewed
Mar 28, 2019
Co-Authored-By: XuHuaiyu <[email protected]>
|
/run-all-tests |
XuHuaiyu
added a commit
to XuHuaiyu/tidb
that referenced
this pull request
Mar 28, 2019
zimulala
pushed a commit
that referenced
this pull request
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #9920
What is changed and how it works?
Make the behavior of group_concat be compatible with the MySQL manual:
Before this commit, we regard every argument as an item of the result of group_concat.
But actually, all the arguments value in one row should be regarded as one item. If any one of the arguments is null, the group_concat result of this row is null.
Check List
Tests
Code changes
Side effects
N/A
Related changes