Skip to content

Commit

Permalink
Server: reduce too many pings (#5528)
Browse files Browse the repository at this point in the history
  • Loading branch information
jackysp authored Sep 23, 2022
1 parent b7b29cb commit cbf94a6
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion dbms/src/Server/FlashGrpcServerHolder.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ FlashGrpcServerHolder::FlashGrpcServerHolder(Context & context, Poco::Util::Laye
diagnostics_service = std::make_unique<DiagnosticsService>(context, config_);
builder.SetOption(grpc::MakeChannelArgumentOption(GRPC_ARG_HTTP2_MIN_RECV_PING_INTERVAL_WITHOUT_DATA_MS, 5 * 1000));
builder.SetOption(grpc::MakeChannelArgumentOption(GRPC_ARG_HTTP2_MIN_SENT_PING_INTERVAL_WITHOUT_DATA_MS, 10 * 1000));
builder.SetOption(grpc::MakeChannelArgumentOption(GRPC_ARG_KEEPALIVE_PERMIT_WITHOUT_CALLS, 1));
// number of grpc thread pool's non-temporary threads, better tune it up to avoid frequent creation/destruction of threads
auto max_grpc_pollers = context.getSettingsRef().max_grpc_pollers;
if (max_grpc_pollers > 0 && max_grpc_pollers <= std::numeric_limits<int>::max())
Expand Down

0 comments on commit cbf94a6

Please sign in to comment.