-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up redundant code for TiFlash #2019
Comments
/cc @birdstorm @solotzg |
I think during the cleanup, one can also try to eliminate warnings. |
A related issue under Apple clang 12.0.5 #1887 |
#2020 this pr could optimize time cost of tics_ghpr_build from 45mins to 14mins if nearly 80% cache hit. @JaySon-Huang |
Great to see that our building CI down to 14 mins! I open this issue mainly for cleaning up redundant codes so that we can have a more clean codebase. This may be good for those new to the TiFlash project and help us if TiFlash gets opened to the public someday. |
Is storageFile related code useless? |
@ywqzzy |
I will remove all of them. |
TiFlash fork from Clickhouse around late 2018. There are lots of useless codes for TiFlash.
StorageKafka
,StorageMySQL
,StorageODBC
andCapnProtoRowInputStream
Remove useless codes #1279StorageDistributed
#3484kvproto
/tipb
get updated Better integration with tipb, kvproto #2110Clickhouse uses XML as the configuration file format but TiFlash uses toml. Seems that TiFlash do not rely on XML anymore.
Clickhouse use zookeeper for replication, but TiFlash rely on PD and TiKV's Raft layer
dbms/tests
#3485These are outdated permission management, resource management from ClickHouse
Something not sure:
We use "DataTypeMyDate"/"DataTypeMyDatetime" for MySQL/TiDB-compatibility, these original data types ported from Clickhouse are useless for TiFlash
We don't use these data type
Possible it is good for speeding up our CI building step #1390.
The text was updated successfully, but these errors were encountered: