Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUNTIME_ASSERT doesn't support 0 or 1 format parameters #4503

Closed
fuzhe1989 opened this issue Mar 30, 2022 · 0 comments · Fixed by #4504
Closed

RUNTIME_ASSERT doesn't support 0 or 1 format parameters #4503

fuzhe1989 opened this issue Mar 30, 2022 · 0 comments · Fixed by #4504
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@fuzhe1989
Copy link
Contributor

Enhancement

RUNTIME_ASSERT will fail to compile when taken 0 or 1 format parameters:

RUNTIME_ASSERT(condition, log); // error!
RUNTIME_ASSERT(condition, log,  "condition fail"); // error!
RUNTIME_ASSERT(condition, log, "condition fail: {}", 5); // pass
@fuzhe1989 fuzhe1989 added the type/enhancement The issue or PR belongs to an enhancement. label Mar 30, 2022
@fuzhe1989 fuzhe1989 mentioned this issue Mar 30, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Mar 30, 2022
@fuzhe1989
*: refine RUNTIME_ASSERT (#4504)
6a22fd6 
close #4503
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: refine RUNTIME_ASSERT fuzhe1989/tiflash
1 participant
@fuzhe1989