Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate DeltaMergeStore into multiple files #5831

Open
4 of 5 tasks
breezewish opened this issue Sep 9, 2022 · 0 comments
Open
4 of 5 tasks

Separate DeltaMergeStore into multiple files #5831

breezewish opened this issue Sep 9, 2022 · 0 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.

Comments

@breezewish
Copy link
Member

breezewish commented Sep 9, 2022 •
edited
Loading

Enhancement

DeltaMergeStore provides most of public interfaces of the storage engine. Currently DeltaMergeStore.cpp/h contains too many things together, which is hard for new developers to understand who are related together.

We can separate it into multiples via the following steps:
@breezewish breezewish added the type/enhancement The issue or PR belongs to an enhancement. label Sep 9, 2022
This was referenced Sep 9, 2022
Merged
Merged
ti-chi-bot pushed a commit that referenced this issue Sep 9, 2022
@breezewish
Storage: (Refactor) Separate ingest impl out (#5832)
4299bef 
ref #5831
@breezewish breezewish added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Sep 9, 2022
@breezewish breezewish mentioned this issue Sep 9, 2022
Merged
13 tasks
ti-chi-bot pushed a commit that referenced this issue Sep 9, 2022
@breezewish
Storage: (Refactor) Separate segment impl out (#5833)
105dde9 
ref #5831
ti-chi-bot pushed a commit that referenced this issue Sep 13, 2022
@breezewish
Storage: (Refactor) Avoid referencing DeltaMergeStore.h (#5835)
6d0cbc8 
ref #5831
@breezewish breezewish mentioned this issue Sep 13, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Sep 13, 2022
@breezewish
Storage: (Refactor) Separate bg tasks out (#5858)
b864055 
ref #5831
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@breezewish