Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support json_unquote function #8334

Closed
yibin87 opened this issue Nov 8, 2023 · 0 comments · Fixed by #8407
Closed

Support json_unquote function #8334

yibin87 opened this issue Nov 8, 2023 · 0 comments · Fixed by #8407
Assignees
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@yibin87
Copy link
Contributor

yibin87 commented Nov 8, 2023

Enhancement

json_unquote only accepts string/json data type. When json type parameter is met, it will be cast as string before being fed into json_unquote like this:
json_unquote(cast(json as string))
TiFlash has already support basic functionality of json_unquote and cast_json_as_string in #6377

Two main work remain todo:

  1. Check if string is valid when quoted.
    tidb implementation
  2. cast_json_as_string: already support cast json as unrestricted string. However, the output string data type can be restricted, like char(20).
    tidb implementation
@yibin87 yibin87 added the type/enhancement The issue or PR belongs to an enhancement. label Nov 8, 2023
@yibin87 yibin87 self-assigned this Nov 8, 2023
ti-chi-bot bot pushed a commit that referenced this issue Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant