Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not get the gc safepoint from PD for new deployed cluster #8356

Closed
JaySon-Huang opened this issue Nov 13, 2023 · 1 comment · Fixed by #8361
Closed

Can not get the gc safepoint from PD for new deployed cluster #8356

JaySon-Huang opened this issue Nov 13, 2023 · 1 comment · Fixed by #8361
Labels
affects-7.5 This bug affects the 7.5.x(LTS) versions. component/storage severity/major type/bug The issue is confirmed as a bug.

Comments

@JaySon-Huang
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

3. What did you see instead (Required)

There are many gc safepoint == 0 logging for new deploy cluster

[2023-11-12T01:18:34.253Z] [2023/11/12 01:18:33.890 +00:00] [INFO] [SchemaSyncService.cpp:193] ["Schema GC begin, last_safepoint=0 safepoint=0"] [source="keyspace=4294967295"] [thread_id=84]
[2023-11-12T01:18:34.253Z] [2023/11/12 01:18:33.890 +00:00] [INFO] [SchemaSyncService.cpp:358] ["Schema GC done, tables_removed=0 databases_removed=0 safepoint=0"] [source="keyspace=4294967295"] [thread_id=84]
[2023-11-12T01:18:34.253Z] [2023/11/12 01:18:33.890 +00:00] [INFO] [SchemaSyncService.cpp:193] ["Schema GC begin, last_safepoint=0 safepoint=0"] [source="keyspace=4294967295"] [thread_id=84]
[2023-11-12T01:18:34.253Z] [2023/11/12 01:18:33.890 +00:00] [INFO] [SchemaSyncService.cpp:358] ["Schema GC done, tables_removed=0 databases_removed=0 safepoint=0"] [source="keyspace=4294967295"] [thread_id=84]
[2023-11-12T01:18:34.254Z] [2023/11/12 01:18:33.891 +00:00] [INFO] [SchemaSyncService.cpp:193] ["Schema GC begin, last_safepoint=0 safepoint=0"] [source="keyspace=4294967295"] [thread_id=84]
[2023-11-12T01:18:34.254Z] [2023/11/12 01:18:33.891 +00:00] [INFO] [SchemaSyncService.cpp:358] ["Schema GC done, tables_removed=0 databases_removed=0 safepoint=0"] [source="keyspace=4294967295"] [thread_id=84]
[2023-11-12T01:18:34.254Z] [2023/11/12 01:18:33.891 +00:00] [INFO] [SchemaSyncService.cpp:193] ["Schema GC begin, last_safepoint=0 safepoint=0"] [source="keyspace=4294967295"] [thread_id=84]
[2023-11-12T01:18:34.254Z] [2023/11/12 01:18:33.891 +00:00] [INFO] [SchemaSyncService.cpp:358] ["Schema GC done, tables_removed=0 databases_removed=0 safepoint=0"] [source="keyspace=4294967295"] [thread_id=84]
[2023-11-12T01:18:34.254Z] [2023/11/12 01:18:33.892 +00:00] [INFO] [SchemaSyncService.cpp:193] ["Schema GC begin, last_safepoint=0 safepoint=0"] [source="keyspace=4294967295"] [thread_id=84]
[2023-11-12T01:18:34.254Z] [2023/11/12 01:18:33.892 +00:00] [INFO] [SchemaSyncService.cpp:358] ["Schema GC done, tables_removed=0 databases_removed=0 safepoint=0"] [source="keyspace=4294967295"] [thread_id=84]
[2023-11-12T01:18:34.254Z] [2023/11/12 01:18:33.892 +00:00] [INFO] [SchemaSyncService.cpp:193] ["Schema GC begin, last_safepoint=0 safepoint=0"] [source="keyspace=4294967295"] [thread_id=84]
[2023-11-12T01:18:34.254Z] [2023/11/12 01:18:33.892 +00:00] [INFO] [SchemaSyncService.cpp:358] ["Schema GC done, tables_removed=0 databases_removed=0 safepoint=0"] [source="keyspace=4294967295"] [thread_id=84]
[2023-11-12T01:18:34.254Z] [2023/11/12 01:18:33.893 +00:00] [INFO] [SchemaSyncService.cpp:193] ["Schema GC begin, last_safepoint=0 safepoint=0"] [source="keyspace=4294967295"] [thread_id=84]
[2023-11-12T01:18:34.254Z] [2023/11/12 01:18:33.893 +00:00] [INFO] [SchemaSyncService.cpp:358] ["Schema GC done, tables_removed=0 databases_removed=0 safepoint=0"] [source="keyspace=4294967295"] [thread_id=84]
[2023-11-12T01:18:34.254Z] [2023/11/12 01:18:33.893 +00:00] [INFO] [SchemaSyncService.cpp:193] ["Schema GC begin, last_safepoint=0 safepoint=0"] [source="keyspace=4294967295"] [thread_id=84]
[2023-11-12T01:18:34.254Z] [2023/11/12 01:18:33.893 +00:00] [INFO] [SchemaSyncService.cpp:358] ["Schema GC done, tables_removed=0 databases_removed=0 safepoint=0"] [source="keyspace=4294967295"] [thread_id=84]

4. What is your TiFlash version? (Required)

master

@JaySon-Huang
Copy link
Contributor Author

After a new tidb cluster deployed, there is an interval that PD will return gc safepoint with 0

>  tiup ctl:nightly pd -u [10.2.12.81:6540](http://10.2.12.81:6540/) -i
Starting component `ctl`: /DATA/disk1/ra_common/.tiup/components/ctl/v7.6.0-alpha-nightly-20231112/ctl pd -u [10.2.12.81:6540](http://10.2.12.81:6540/) -i
» service-gc-safepoint
{
  "service_gc_safe_points": [
    {
      "service_id": "gc_worker",
      "expired_at": 9223372036854775807,
      "safe_point": 445603590956646400
    }
  ],
  "gc_safe_point": 0 <-- tiflash use this value
}

This will lead to SchemaSyncService::gc running repeatedly. This results in lots of useless logging and getting gc safepoint from pd frequently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-7.5 This bug affects the 7.5.x(LTS) versions. component/storage severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants