Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change the type of task count metric as Counter #9595

Closed
guo-shaoge opened this issue Nov 7, 2024 · 0 comments · Fixed by #9594
Closed

change the type of task count metric as Counter #9595

guo-shaoge opened this issue Nov 7, 2024 · 0 comments · Fixed by #9594
Labels
affects-8.5 This bug affects the 8.5.x(LTS) versions. component/compute type/enhancement The issue or PR belongs to an enhancement.

Comments

@guo-shaoge
Copy link
Contributor

Enhancement

we cannot observe very fast mpp task by checking task count metric, because Decrement is called immediately after Increment before prometheus server pull metric data.
@guo-shaoge guo-shaoge added the type/enhancement The issue or PR belongs to an enhancement. label Nov 7, 2024
@guo-shaoge guo-shaoge mentioned this issue Nov 7, 2024
Merged
12 tasks
@ti-chi-bot ti-chi-bot bot closed this as completed in #9594 Nov 8, 2024
@ti-chi-bot ti-chi-bot bot closed this as completed in 750c4de Nov 8, 2024
@JaySon-Huang JaySon-Huang added the affects-8.5 This bug affects the 8.5.x(LTS) versions. label Jan 6, 2025
@ti-chi-bot ti-chi-bot mentioned this issue Jan 7, 2025
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jan 7, 2025
@ti-chi-bot @guo-shaoge
refine resource group task_count metric (#9594) (#9768)
34e5c14 
close #9595

Signed-off-by: guo-shaoge <[email protected]>

Co-authored-by: guo-shaoge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-8.5 This bug affects the 8.5.x(LTS) versions. component/compute type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refine resource group task_count metric guo-shaoge/tiflash
2 participants
@JaySon-Huang @guo-shaoge