-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stop finding a task if it is canncelled #1778
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
/merge |
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
/merge |
/run-all-tests |
@fzhedu merge failed. |
/run-all-tests |
1 similar comment
/run-all-tests |
/merge |
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
@fzhedu merge failed. |
/run-all-tests |
/run-cherry-picker |
cherry pick to release-5.0 in PR #1784 |
What problem does this PR solve?
Issue Number: close #1440
Problem Summary:
wait_for will stop until timeout or the lameda function returning true. So when finding a task, if it is cancelled,
findTaskWithTimeout
should return quickly and return errors, rather than the lameda function returning false and waiting for timeout.What is changed and how it works?
Proposal: xxx
What's Changed:
Check List
Tests
the query returns a expected error.
Release note