Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clang-tidy warnings for a batch of files #3245

Merged
merged 6 commits into from
Oct 20, 2021
Merged

Fix clang-tidy warnings for a batch of files #3245

merged 6 commits into from
Oct 20, 2021

Conversation

dragonly
Copy link
Contributor

@dragonly dragonly commented Oct 18, 2021

What problem does this PR solve?

Issue Number: #2877, #2878, #2880, #2881, #2882, #2885

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Release note

None

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@dragonly dragonly requested a review from fuzhe1989 October 18, 2021 07:52
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 18, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fuzhe1989

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 18, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@@ -45,7 +45,7 @@ class ConfigReloader
void reload() { reloadIfNewer(/* force */ true, /* throw_on_error */ true); }

protected:
virtual void reloadIfNewer(bool force, bool throw_on_error);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove the virtual?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise it prompts with this

$ clang-tidy-12 -p build/compile_commands.json dbms/src/Common/Config/ConfigReloader.cpp
26966 warnings generated.
/mnt/pingcap/tics/dbms/src/Common/Config/ConfigReloader.cpp:22:9: error: Call to virtual method 'ConfigReloader::reloadIfNewer' during construction bypasses virtual dispatch [clang-analyzer-optin.cplusplus.VirtualCall,-warnings-as-errors]
        reloadIfNewer(/* force = */ true, /* throw_on_error = */ true);
        ^
/mnt/pingcap/tics/dbms/src/Common/Config/ConfigReloader.cpp:21:9: note: Assuming 'already_loaded' is false
    if (!already_loaded)
        ^
/mnt/pingcap/tics/dbms/src/Common/Config/ConfigReloader.cpp:21:5: note: Taking true branch
    if (!already_loaded)
    ^
/mnt/pingcap/tics/dbms/src/Common/Config/ConfigReloader.cpp:22:9: note: Call to virtual method 'ConfigReloader::reloadIfNewer' during construction bypasses virtual dispatch
        reloadIfNewer(/* force = */ true, /* throw_on_error = */ true);
        ^

@@ -100,16 +100,16 @@ void TOMLConfiguration::enumerate(const std::string & key, Keys & range) const
if (!table)
return;

for (auto it = table->begin(); it != table->end(); it++)
range.push_back(it->first);
for (auto & it : *table)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for (auto & it : *table)
for (const auto & it : *table)

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@dragonly
Copy link
Contributor Author

/run-all-tests

@fuzhe1989
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@fuzhe1989: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 20, 2021
@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d1f890e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 20, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@ti-chi-bot
Copy link
Member

@dragonly: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 9bdd876 into pingcap:master Oct 20, 2021
@JaySon-Huang JaySon-Huang deleted the dragonly/clang-tidy-batch-3 branch October 21, 2021 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants