[FLASH-175]eliminate assumption of existence of tidb_rowid #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidezhu
changed the title
|
/rebuild |
1 similar comment
|
/rebuild |
innerr
reviewed
Apr 4, 2019
dbms/src/Debug/MockTiDB.cpp
Outdated
| @@ -127,7 +131,8 @@ TableID MockTiDB::newTable(const String & database_name, const String & table_na | |||
| table_info.columns.emplace_back(column_info); | |||
| } | |||
|
|
|||
| table_info.pk_is_handle = false; | |||
| table_info.pk_is_handle = !(primary_key.empty()); | |||
|
/rebuild |
|
/rebuild |
2 similar comments
|
/rebuild |
|
/rebuild |
zanmato1984
reviewed
Apr 9, 2019
| } | ||
| } | ||
| block = readProcess(block, typeid_cast<const ColumnInt32 *>(handle_column.column.get())); | ||
| } else |
There was a problem hiding this comment.
Is there a chance that the handle column is of type other than int64 or int32? I.e. int16 or int8?
Try creating a tidb table with single column primary key of type short or tiny int or whatever, then you'll see.
There was a problem hiding this comment.
I have included other cases when the handle column is of other int type.
solotzg
reviewed
Apr 9, 2019
| @@ -22,60 +76,21 @@ Block RangesFilterBlockInputStream::readImpl() | |||
| throw Exception("RangesFilterBlockInputStream: block without _tidb_rowid.", ErrorCodes::LOGICAL_ERROR); | |||
|
|
|||
| const ColumnWithTypeAndName & handle_column = block.getByName(handle_col_name); | |||
| const ColumnInt64 * column = typeid_cast<const ColumnInt64 *>(handle_column.column.get()); | |||
| if (!column) | |||
| std::string handle_column_type_name = std::string(handle_column.type->getFamilyName()); | |||
There was a problem hiding this comment.
reduce unnecessary memory allocation.
zanmato1984
reviewed
Apr 9, 2019
dbms/src/Debug/MockTiDB.cpp
Outdated
| @@ -67,7 +67,7 @@ void MockTiDB::dropTable(const String & database_name, const String & table_name | |||
| tables_by_name.erase(it_by_name); | |||
| } | |||
|
|
|||
| TableID MockTiDB::newTable(const String & database_name, const String & table_name, const ColumnsDescription & columns) | |||
| TableID MockTiDB::newTable(const String & database_name, const String & table_name, const ColumnsDescription & columns, const String & primary_key, bool pk_is_handle) | |||
There was a problem hiding this comment.
You don't need argument pk_is_handle, it can be inferred by the given column list and pk (and this is actually how TiDB does):
- Single pk column.
- The pk column is of integral type, i.e. int8/16/24/32/64.
Besides, you have to be clear of the function semantic by answering the following questions:
- Does it allow specifying multiple primary keys? If no (as it already is), it probably means that you are assuming the only primary key specified is
valid. But it might be not, as it could be of non-integral type. - If the answer to the above question is yes, it means you will check the the given primary key list and decide whether
pk_is_handle, and error out or just let it be. - Either way, you are missing something.
There was a problem hiding this comment.
- Eliminate pk_is_handle and pk column can be other kinds of int type now.
- The current semantic is user can only specify one column to be the primary key and it must be one of int type. The reason for this choice is that when the primary key contain multiple columns, table_info structure does not store the order between multiple columns inside a primary key. And parse a primary key which consists of multiple columns is more troublesome and the information is currently useless.
|
Fixed in #47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en