Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove qb_join_subquery_alias and replaced by join_executor_id #3937

Merged
merged 14 commits into from
Feb 8, 2022
Merged

remove qb_join_subquery_alias and replaced by join_executor_id #3937

merged 14 commits into from
Feb 8, 2022

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Jan 24, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

remove getProfileStreamsMapForJoinBuildSide and replaced by build_side_root_executor_id from getJoinExecuteInfoMap

replace qb_join_subquery_alias by join_executor_id

remove ProfileStreamsInfo and use BlockInputStreams directly

move collectAllPossibleChildrenJoinSubqueryAlias to DAGContext and traverse DAGRequest directly

fix clang-tidy err Call to virtual method getName during construction bypasses virtual dispatch for AggregatingBlockInputStream, ConcatBlockInputStream, ExchangeSender, HashJoinBuildBlockInputStream, PartialSortingBlockInputStream, TiRemoteBlockInputStream.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 24, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fuzhe1989

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 24, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 24, 2022

/run-integration-test

1 similar comment
@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 24, 2022

/run-integration-test

@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 26, 2022

/run-integration-test

@SeaRise SeaRise requested a review from fuzhe1989 January 26, 2022 07:37
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 26, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 26, 2022

/run-integration-test

@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 27, 2022

/run-integration-test

@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 27, 2022

/run-integration-test

@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 27, 2022

/run-integration-test

fuzhe1989
fuzhe1989 reviewed Feb 7, 2022
View reviewed changes
Copy link
Contributor

@fuzhe1989 fuzhe1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost LGTM

dbms/src/Flash/Statistics/traverseExecutors.h Outdated Show resolved Hide resolved
dbms/src/Flash/Coprocessor/DAGContext.h Outdated Show resolved Hide resolved
dbms/src/Flash/Statistics/traverseExecutors.h Outdated Show resolved Hide resolved
@SeaRise
Copy link
Contributor Author

SeaRise commented Feb 7, 2022

/run-integration-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 7, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Feb 8, 2022

/merge

@ti-chi-bot
Copy link
Member

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a9a37f8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 8, 2022
@ti-chi-bot
Copy link
Member

@SeaRise: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Feb 8, 2022

Coverage for changed files

Filename                                           Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DataStreams/AggregatingBlockInputStream.h                2                 2     0.00%           2                 2     0.00%           4                 4     0.00%           0                 0         -
DataStreams/ConcatBlockInputStream.h                    10                 0   100.00%           5                 0   100.00%          25                 0   100.00%           4                 0   100.00%
DataStreams/ExchangeSender.h                             4                 4     0.00%           4                 4     0.00%           8                 8     0.00%           0                 0         -
DataStreams/HashJoinBuildBlockInputStream.h              3                 3     0.00%           3                 3     0.00%           6                 6     0.00%           0                 0         -
DataStreams/PartialSortingBlockInputStream.h             6                 6     0.00%           6                 6     0.00%           8                 8     0.00%           0                 0         -
DataStreams/TiRemoteBlockInputStream.h                  89                89     0.00%          12                12     0.00%         136               136     0.00%          50                50     0.00%
Flash/Coprocessor/DAGContext.cpp                        86                65    24.42%          21                14    33.33%         183               149    18.58%          62                54    12.90%
Flash/Coprocessor/DAGContext.h                          28                10    64.29%          21                 9    57.14%          59                17    71.19%           8                 3    62.50%
Flash/Coprocessor/DAGQueryBlock.cpp                    103                65    36.89%           4                 1    75.00%         143               101    29.37%          72                46    36.11%
Flash/Coprocessor/DAGQueryBlock.h                        2                 1    50.00%           2                 1    50.00%           4                 1    75.00%           0                 0         -
Flash/Coprocessor/DAGQueryBlockInterpreter.cpp         348               348     0.00%          43                43     0.00%         818               818     0.00%         278               278     0.00%
Flash/Coprocessor/DAGQuerySource.cpp                    14                 5    64.29%           4                 3    25.00%          35                16    54.29%          10                 4    60.00%
Flash/Coprocessor/DAGResponseWriter.cpp                 68                68     0.00%           4                 4     0.00%         122               122     0.00%          66                66     0.00%
Flash/Statistics/ExecutorStatistics.h                   15                15     0.00%           8                 8     0.00%          62                62     0.00%           4                 4     0.00%
Flash/Statistics/traverseExecutors.h                    30                25    16.67%          12                10    16.67%          54                43    20.37%          16                14    12.50%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                  808               706    12.62%         151               120    20.53%        1667              1491    10.56%         570               519     8.95%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16349      9712             40.60%    179215  98408        45.09%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 5330462 into pingcap:master Feb 8, 2022
@SeaRise SeaRise deleted the remove_join_alias branch February 8, 2022 03:17
@SeaRise SeaRise mentioned this pull request Jun 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuzhe1989 fuzhe1989 fuzhe1989 approved these changes

@windtalker windtalker Awaiting requested review from windtalker

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SeaRise @ti-chi-bot @sre-bot @fuzhe1989