MPP: implement minTSO Scheduler #4044
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note
ti-chi-bot
removed
the
needs-rebase
|
/run-all-tests |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
|
/run-all-tests |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
|
/run-integration-tests |
ti-chi-bot
added
the
needs-rebase
fzhedu
force-pushed
the
minTSO
branch
2 times, most recently
from
6280685 to
1aef1c2
Compare
ti-chi-bot
removed
the
needs-rebase
|
/run-all-tests |
fzhedu
changed the title
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
|
/run-all-tests |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
dbms/src/Flash/Mpp/MPPTask.cpp
Outdated
| scheduled = true; | ||
| schedule_cv.notify_one(); | ||
| } | ||
| void MPPTask::deleteAndScheduleQueries() |
There was a problem hiding this comment.
It might be more natural to remove this method in MPPTask, and invoke the scheduler's one in Manager directly.
There was a problem hiding this comment.
but Manager cannot get the scheduler.
| { | ||
| /// find a normal query | ||
| UInt64 current_query_id = 0; | ||
| query_task_set = task_manager->getQueryTaskSetWithoutLock(current_query_id); |
There was a problem hiding this comment.
Why do we query task with query_id 0?
ti-chi-bot
added
status/LGT2
|
/merge |
|
@fzhedu: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 6a3add1
|
ti-chi-bot
added
the
status/can-merge
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
|
/merge |
|
@fzhedu: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
ti-chi-bot
removed
the
needs-rebase
|
/merge |
|
@fzhedu: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/run-all-tests |
|
/merge |
|
@fzhedu: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/rebuild |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
|
/run-all-tests |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
fzhedu
removed
the
do-not-merge/hold
|
/merge |
|
@fzhedu: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
What problem does this PR solve?
Issue Number: close #4256
Issue Number: close #4256
design doc 1
design doc 0
Problem Summary:
implement minTSO Scheduler
which schedule tasks from a query one by one
TODO
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note