Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve LogWithPrefix of mpp #4209

Merged
merged 16 commits into from
Mar 21, 2022
Merged

Improve LogWithPrefix of mpp #4209

merged 16 commits into from
Mar 21, 2022

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Mar 9, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #4249

Problem Summary:

What is changed and how it works?

and fix clang-tidy-warnings for dbms/src/Interpreters/Aggregator

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 9, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • LittleFall
  • fuzhe1989

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 9, 2022
fuzhe1989
fuzhe1989 reviewed Mar 9, 2022
View reviewed changes
Copy link
Contributor

@fuzhe1989 fuzhe1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to review our design of LogWithPrefix. The main problem could be that we don't know if the log ptr passed in has already been appended a prefix.

dbms/src/DataStreams/ParallelInputsProcessor.h Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 14, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 15, 2022

/rebuild

@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 16, 2022

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 17, 2022

[ExchangeReceiver.cpp:626] ["MPPTask:query:431882918311231489,task:4 ExchangeReceiver_64 ExchangeReceiver tunnel3+4 connection end. meet error: false, err msg: , current alive connections: 0"] [thread_id=74]

@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 17, 2022

/hold cancel

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 17, 2022
@SeaRise SeaRise requested a review from fuzhe1989 March 17, 2022 08:02
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 19, 2022
@SeaRise SeaRise requested a review from LittleFall March 21, 2022 05:04
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 21, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 21, 2022

/merge

@ti-chi-bot
Copy link
Member

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6f7b39b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 21, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 21, 2022

Coverage for changed files

Filename                                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/Exception.cpp                                        102                89    12.75%          13                10    23.08%         154               114    25.97%          40                37     7.50%
DataStreams/ParallelAggregatingBlockInputStream.cpp          93                93     0.00%          12                12     0.00%         150               150     0.00%          64                64     0.00%
DataStreams/ParallelInputsProcessor.h                        85                85     0.00%          17                17     0.00%         153               153     0.00%          44                44     0.00%
DataStreams/SharedQueryBlockInputStream.h                    49                49     0.00%          10                10     0.00%          87                87     0.00%          28                28     0.00%
DataStreams/UnionBlockInputStream.h                          96                96     0.00%          24                24     0.00%         133               133     0.00%          48                48     0.00%
Flash/Coprocessor/DAGContext.cpp                             89                65    26.97%          24                16    33.33%         200               163    18.50%          62                52    16.13%
Flash/Coprocessor/DAGQueryBlockInterpreter.cpp              390               390     0.00%          45                45     0.00%         876               876     0.00%         312               312     0.00%
Flash/Mpp/ExchangeReceiver.cpp                              298               298     0.00%          31                31     0.00%         450               450     0.00%         186               186     0.00%
Flash/Mpp/MPPTask.cpp                                       409               409     0.00%          21                21     0.00%         340               340     0.00%         184               184     0.00%
Interpreters/Aggregator.cpp                                2617              2617     0.00%          74                74     0.00%        1602              1602     0.00%        1200              1200     0.00%
Interpreters/Aggregator.h                                   965               965     0.00%          39                39     0.00%         193               193     0.00%         398               398     0.00%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                      5193              5156     0.71%         310               299     3.55%        4338              4261     1.78%        2566              2553     0.51%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17021      9575             43.75%    191708  97067        49.37%

full coverage report (for internal network access only)

@ti-chi-bot
Copy link
Member

@SeaRise: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 21, 2022

Coverage for changed files

Filename                                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/Exception.cpp                                        102                89    12.75%          13                10    23.08%         154               114    25.97%          40                37     7.50%
DataStreams/ParallelAggregatingBlockInputStream.cpp          93                93     0.00%          12                12     0.00%         150               150     0.00%          64                64     0.00%
DataStreams/ParallelInputsProcessor.h                        85                85     0.00%          17                17     0.00%         153               153     0.00%          44                44     0.00%
DataStreams/SharedQueryBlockInputStream.h                    49                49     0.00%          10                10     0.00%          87                87     0.00%          28                28     0.00%
DataStreams/UnionBlockInputStream.h                          96                96     0.00%          24                24     0.00%         133               133     0.00%          48                48     0.00%
Flash/Coprocessor/DAGContext.cpp                             89                65    26.97%          24                16    33.33%         200               163    18.50%          62                52    16.13%
Flash/Coprocessor/DAGQueryBlockInterpreter.cpp              390               390     0.00%          45                45     0.00%         876               876     0.00%         312               312     0.00%
Flash/Mpp/ExchangeReceiver.cpp                              298               298     0.00%          31                31     0.00%         450               450     0.00%         186               186     0.00%
Flash/Mpp/MPPTask.cpp                                       409               409     0.00%          21                21     0.00%         340               340     0.00%         184               184     0.00%
Interpreters/Aggregator.cpp                                2617              2617     0.00%          74                74     0.00%        1602              1602     0.00%        1200              1200     0.00%
Interpreters/Aggregator.h                                   965               965     0.00%          39                39     0.00%         193               193     0.00%         398               398     0.00%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                      5193              5156     0.71%         310               299     3.55%        4338              4261     1.78%        2566              2553     0.51%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17021      9574             43.75%    191708  97061        49.37%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 2bd5626 into pingcap:master Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuzhe1989 fuzhe1989 fuzhe1989 approved these changes

@LittleFall LittleFall LittleFall approved these changes

@windtalker windtalker Awaiting requested review from windtalker

@JaySon-Huang JaySon-Huang Awaiting requested review from JaySon-Huang

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incomplete MPPTask log
5 participants
@SeaRise @ti-chi-bot @sre-bot @fuzhe1989 @LittleFall