fix coredump when TiFlash shutdown #4272
Conversation
Signed-off-by: bestwoody <[email protected]>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
ti-chi-bot
added
the
size/M
|
Could you give some explainations about why TiFlash server will coredump without this pr? |
|
/run-all-tests |
1.when cq is shutdown， |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
dbms/src/Server/Server.cpp
Outdated
| @@ -649,6 +653,7 @@ class Server::FlashGrpcServerHolder | |||
|
|
|||
| private: | |||
| Poco::Logger * log; | |||
| std::shared_ptr<bool> is_shutdown; | |||
There was a problem hiding this comment.
do we need to use atomic bool here?
There was a problem hiding this comment.
yes... I missed. good spot
Signed-off-by: bestwoody <[email protected]>
…to bugfix_of_async_server
| @@ -627,6 +628,9 @@ class Server::FlashGrpcServerHolder | |||
|
|
|||
| ~FlashGrpcServerHolder() | |||
| { | |||
| *is_shutdown = true; | |||
| const int wait_calldata_after_shutdown_interval_ms = 500; | |||
| std::this_thread::sleep_for(std::chrono::milliseconds(wait_calldata_after_shutdown_interval_ms)); // sleep 500ms to let operations of calldata called by MPPTunnel done. | |||
There was a problem hiding this comment.
this is not stable, we can refine it later.
ti-chi-bot
added
status/LGT2
|
/merge |
|
@bestwoody: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 176c5e9
|
ti-chi-bot
added
the
status/can-merge
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
|
@bestwoody: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
Signed-off-by: bestwoody [email protected]
What problem does this PR solve?
Issue Number: close #4262
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note