fix bug that ExchangeReceiver is not cancelled if exception happens in union/agg block input stream (#4285)

[ti-chi-bot]

This is an automated cherry-pick of #4285

Signed-off-by: xufei [email protected]

What problem does this PR solve?

Issue Number: ref #4229

Problem Summary:

some backgrounds:

• For every BlockInputStream, there is a cancel(bool kill) method to cancel the current and all its children input streams.
• In UnionBlockInputStream/ParallelAggregatingBlockInputStream, if some exception happens during processor.process(), it will cancel the BlockInputStream in processor. However, it use silent cancel(false) to do this, which will be ignored by TiRemteBlockInputStream, so the remote_reader in TiRemoteBlockInputStream is not cancelled by cancel(false).
• Due to the implementation of cancel, if a input stream is cancel once, all the subsequent cancels(including cancel(true)) will be ignored.
• MPPTask will use cancel(true) to cancel its BlockInputStream, and all the remote_reader in TiRemoteInputStream

problem
If a input stream is cancelled due to exception in UnionBlockInputStream/ParallelAggregatingBlockInputStream, Cancel query can not cancel this input stream anymore, leaving remote_reader un-cancelled, which may block the MPP query forever.

What is changed and how it works?

In UnionBlockInputStream/ParallelAggregatingBlockInputStream, if some exception happens during processor.process(), use cancel(true) to cancel the BlockInputStream in processor.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• bestwoody
• windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[CLAassistant]

All committers have signed the CLA.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[windtalker]

LGTM

[windtalker]

/rebuild

[windtalker]

/merge

[ti-chi-bot]

@windtalker: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 5ccbd69

[ti-chi-bot]

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[sre-bot]

lines: 43.3% (49812 out of 115147)
branches: 6.4% (81432 out of 1264046)

[sre-bot]

lines: 43.2% (49811 out of 115178)
branches: 6.4% (81421 out of 1264195)