Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug that TiFlash will crash when enable both async_grpc_client and local_tunnel #4322

Merged
merged 2 commits into from
Mar 17, 2022
Merged

Fix bug that TiFlash will crash when enable both async_grpc_client and local_tunnel #4322

merged 2 commits into from
Mar 17, 2022

Conversation

fuzhe1989
Copy link
Contributor

Signed-off-by: fuzhe1989 [email protected]

What problem does this PR solve?

Issue Number: close #4321

Problem Summary:

When enable both async_grpc_client and local_tunnel, and the ExchangeReceiver has multiple connections, then TiFlash might crash due to access out of bound.

This bug can't be detected from ci test since ci env only has one node.

Root cause: the reactor uses req->source_index as the array index, however when there's a local connection, the array size is less than the connction count by 1.

What is changed and how it works?

Do not use source_index, directly use handler pointer.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

update
9ab1cb9 
Signed-off-by: fuzhe1989 <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 17, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bestwoody
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed labels Mar 17, 2022
@fuzhe1989 fuzhe1989 requested a review from fzhedu March 17, 2022 05:59
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 17, 2022
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.0 Type: Need cherry pick to release-6.0 and removed do-not-merge/needs-triage-completed labels Mar 17, 2022
@fuzhe1989
Copy link
Contributor Author

/run-all-tests

fzhedu
fzhedu reviewed Mar 17, 2022
View reviewed changes
dbms/src/Flash/Mpp/ExchangeReceiver.cpp
Comment on lines +398 to +399
if (!handler->retrySucceed(now))
tmp.push_back(handler);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the now should before this line to get the real now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

retrySucced is expected light enough, so we only need to call Clock::now() once.

fzhedu
fzhedu reviewed Mar 17, 2022
View reviewed changes
Copy link
Contributor

@fzhedu fzhedu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you test this PR when enable or disable local tunnel?

bestwoody
bestwoody approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@bestwoody bestwoody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 17, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 17, 2022

Coverage for changed files

Filename                                                                                               Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Flash/Mpp/ExchangeReceiver.cpp         288               288     0.00%          31                31     0.00%         442               442     0.00%         186               186     0.00%
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                      288               288     0.00%          31                31     0.00%         442               442     0.00%         186               186     0.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16971      9542             43.77%    191213  96832        49.36%

full coverage report (for internal network access only)

windtalker
windtalker approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 17, 2022
@fuzhe1989
Copy link
Contributor Author

@fzhedu now the ci will test:

  1. enable both
  2. only enable async client
  3. only enable local tunnel

The missing part is to test them on multi-node env.

@fuzhe1989
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@fuzhe1989: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7c56fea

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 17, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 17, 2022

Coverage for changed files

Filename                                                                                               Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Flash/Mpp/ExchangeReceiver.cpp         288               288     0.00%          31                31     0.00%         442               442     0.00%         186               186     0.00%
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                      288               288     0.00%          31                31     0.00%         442               442     0.00%         186               186     0.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16974      9545             43.77%    191228  96866        49.35%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 392d7d2 into pingcap:master Mar 17, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: cannot checkout release-6.0: error checking out release-6.0: exit status 1. output: error: pathspec 'release-6.0' did not match any file(s) known to git

@fuzhe1989 fuzhe1989 deleted the fuzhe/fix_reactor branch March 17, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzhedu fzhedu fzhedu left review comments

@windtalker windtalker windtalker approved these changes

@bestwoody bestwoody bestwoody approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.0 Type: Need cherry pick to release-6.0 release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tiflash crash in exchange receiver
6 participants
@fuzhe1989 @ti-chi-bot @sre-bot @windtalker @fzhedu @bestwoody