*: use MPMCQueue in UnionBlockInputStream and SharedQueryBlockInputStream #4418
Conversation
Signed-off-by: fuzhe1989 <[email protected]>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
do-not-merge/needs-linked-issue
release-note-none
|
/run-all-tests |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
Signed-off-by: fuzhe1989 <[email protected]>
|
/run-all-tests |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
Signed-off-by: fuzhe1989 [email protected]
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
/rebuild |
|
/run-all-tests |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
|
can we add some tests? |
Signed-off-by: fuzhe1989 <[email protected]>
ti-chi-bot
added
the
needs-rebase
Signed-off-by: fuzhe1989 <[email protected]>
ti-chi-bot
removed
the
needs-rebase
Signed-off-by: fuzhe1989 <[email protected]>
| if (isCancelled() || read_suffixed) | ||
| return {}; | ||
| } while (!queue.tryPop(block, try_action_millisecionds)); | ||
| if (!isCancelled()) |
There was a problem hiding this comment.
what if !exception_msg.empty() && !isCancelled() happens?
There was a problem hiding this comment.
it's dangerous to visit exception_msg before waitThread. don't worry about the blocking, waitThread will be called only when the fetchBlocks itself finishes the queue.
There was a problem hiding this comment.
this comment, I'm not worry about blocking. My point is that exception_msg may not be empty and !isCanceled is false, then we miss the throw Exception(exception_msg); in waitThread();
There was a problem hiding this comment.
if the inputstream is canceled, then the exception_msg doesn't matter, we can safely ignore it.
There was a problem hiding this comment.
I'm not sure... @windtalker PTAL
Signed-off-by: fuzhe1989 <[email protected]>
Signed-off-by: fuzhe1989 <[email protected]>
ti-chi-bot
added
size/L
Signed-off-by: fuzhe1989 <[email protected]>
|
/run-all-tests |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
ti-chi-bot
added
status/LGT2
|
/merge |
|
@fuzhe1989: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 7a1bf90
|
ti-chi-bot
added
the
status/can-merge
|
@fuzhe1989: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
Signed-off-by: fuzhe1989 [email protected]
What problem does this PR solve?
Issue Number: close #4419
Problem Summary:
What is changed and how it works?
What we could acheive from
MPMCQueue:Check List
Tests
Side effects
Documentation
Release note