PageStorage: Fix data race in BlobStore

[JaySon-Huang]

What problem does this PR solve?

Issue Number: close #4545

Problem Summary:

What is changed and how it works?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• SchrodingerZhu
• jiaqizho

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[jiaqizho]

LGTM with a suggestion: how about changing back stat->lock() to hold the lock from the thread. then we won't pass the lock_guard many functions.

[JaySon-Huang]

LGTM with a suggestion: how about changing back stat->lock() to hold the lock from the thread. then we won't pass the lock_guard many functions.

Adding the lock_guard to the signature of the function is mainly to remind the caller should take care of the concurrent problem, and easier for reviewing

[JaySon-Huang]

/merge

[ti-chi-bot]

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 3764320

[JaySon-Huang]

/rebuild

[ti-chi-bot]

@JaySon-Huang: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[JaySon-Huang]

/merge

[ti-chi-bot]

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 8958c6d

[sre-bot]

Coverage for changed files

Filename                       Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
BlobStore.cpp                      376               114    69.68%          39                 3    92.31%         820               210    74.39%         242                91    62.40%
BlobStore.h                          7                 1    85.71%           7                 1    85.71%          25                10    60.00%           0                 0         -
tests/gtest_blob_store.cpp        3589               596    83.39%          17                 0   100.00%         694                 0   100.00%        1114               525    52.87%
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                             3972               711    82.10%          63                 4    93.65%        1539               220    85.71%        1356               616    54.57%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17002      9513             44.05%    191368  96361        49.65%

full coverage report (for internal network access only)