Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpreter: Hand write tipb::Executor. #4632

Merged
merged 18 commits into from
Apr 15, 2022

Conversation

ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Apr 12, 2022

What problem does this PR solve?

Issue Number: ref #4609

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 12, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Lloyd-Pottiger
  • SeaRise

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 12, 2022
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 12, 2022
@SeaRise SeaRise self-requested a review April 13, 2022 08:48
@ywqzzy ywqzzy changed the title [WIP] Mock Executors. Hand write tipb::Executor. Apr 13, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 13, 2022
@ywqzzy ywqzzy changed the title Hand write tipb::Executor. Interpreter: Hand write tipb::Executor. Apr 13, 2022
dbms/src/TestUtils/InterpreterTestUtils.h Outdated Show resolved Hide resolved
dbms/src/TestUtils/mockExecutor.h Outdated Show resolved Hide resolved
dbms/src/TestUtils/tests/gtest_mock_executors.cpp Outdated Show resolved Hide resolved
dbms/src/TestUtils/InterpreterTestUtils.h Outdated Show resolved Hide resolved
dbms/src/TestUtils/InterpreterTestUtils.h Outdated Show resolved Hide resolved
dbms/src/TestUtils/mockExecutor.cpp Outdated Show resolved Hide resolved
dbms/src/TestUtils/mockExecutor.cpp Outdated Show resolved Hide resolved
dbms/src/TestUtils/mockExecutor.cpp Show resolved Hide resolved
@ywqzzy ywqzzy requested a review from Lloyd-Pottiger April 14, 2022 10:33
@SeaRise SeaRise self-requested a review April 14, 2022 10:37
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Apr 14, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Apr 14, 2022

Coverage for changed files

Filename                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Debug/astToExecutor.cpp                          500               254    49.20%          46                12    73.91%        1311               657    49.89%         498               271    45.58%
TestUtils/InterpreterTestUtils.cpp                32                 5    84.38%           6                 1    83.33%          71                19    73.24%          12                 4    66.67%
TestUtils/InterpreterTestUtils.h                   7                 2    71.43%           5                 1    80.00%          21                 5    76.19%           0                 0         -
TestUtils/mockExecutor.cpp                        46                 9    80.43%          23                 3    86.96%         160                34    78.75%          22                 8    63.64%
TestUtils/mockExecutor.h                           3                 0   100.00%           3                 0   100.00%           7                 0   100.00%           0                 0         -
TestUtils/tests/gtest_mock_executors.cpp         179               133    25.70%           7                 0   100.00%         126                 0   100.00%          28                28     0.00%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                            767               403    47.46%          90                17    81.11%        1696               715    57.84%         560               311    44.46%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17069      9511             44.28%    192357  96478        49.84%

full coverage report (for internal network access only)

Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but maybe add some comments for readability?

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 14, 2022
dbms/src/TestUtils/InterpreterTestUtils.h Outdated Show resolved Hide resolved
dbms/src/TestUtils/InterpreterTestUtils.h Outdated Show resolved Hide resolved
dbms/src/TestUtils/mockExecutor.cpp Outdated Show resolved Hide resolved
dbms/src/TestUtils/mockExecutor.cpp Outdated Show resolved Hide resolved
dbms/src/TestUtils/mockExecutor.h Outdated Show resolved Hide resolved
dbms/src/TestUtils/tests/gtest_mock_executors.cpp Outdated Show resolved Hide resolved
dbms/src/TestUtils/mockExecutor.h Outdated Show resolved Hide resolved
@ywqzzy ywqzzy requested a review from SeaRise April 15, 2022 06:44
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 15, 2022
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Apr 15, 2022

/merge

@ti-chi-bot
Copy link
Member

@ywqzzy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e9dd228

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 15, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Apr 15, 2022

Coverage for changed files

Filename                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Debug/astToExecutor.cpp                          500               253    49.40%          46                12    73.91%        1311               657    49.89%         498               269    45.98%
TestUtils/InterpreterTestUtils.cpp                32                 5    84.38%           6                 1    83.33%          75                19    74.67%          12                 4    66.67%
TestUtils/InterpreterTestUtils.h                   7                 3    57.14%           5                 2    60.00%          22                10    54.55%           0                 0         -
TestUtils/mockExecutor.cpp                        47                11    76.60%          27                 6    77.78%         173                40    76.88%          22                 7    68.18%
TestUtils/mockExecutor.h                           4                 1    75.00%           4                 1    75.00%          10                 3    70.00%           0                 0         -
TestUtils/tests/gtest_mock_executors.cpp         181               133    26.52%           8                 0   100.00%         111                 0   100.00%          28                28     0.00%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                            771               406    47.34%          96                22    77.08%        1702               729    57.17%         560               308    45.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17075      9516             44.27%    192371  96481        49.85%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit bd50b0e into pingcap:master Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants