Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix gettid compile error #4704

Merged
merged 4 commits into from
Apr 19, 2022
Merged

*: fix gettid compile error #4704

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
687c545
update.
ywqzzy Apr 19, 2022
ed3ac24
update.
ywqzzy Apr 19, 2022
6ef762d
Merge branch 'master' into fix_gettid_compile_error
ywqzzy Apr 19, 2022
1508ccc
Merge branch 'master' into fix_gettid_compile_error
ywqzzy Apr 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dbms/src/Storages/BackgroundProcessingPool.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,12 @@
#ifdef __linux__
#include <sys/syscall.h>
#include <unistd.h>
inline static pid_t gettid()
inline static pid_t getTid()
{
return syscall(SYS_gettid);
}
#elif
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct.

BackgroundProcessingPool.cpp:36:6: error: expected value in expression
#elif
     ^
BackgroundProcessingPool.cpp:153:21: error: use of undeclared identifier 'gettid'
        addThreadId(gettid());

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#elif change to #else

inline static pid_t gettid()
inline static pid_t getTid()
{
return -1;
}
Expand Down Expand Up @@ -150,7 +150,7 @@ void BackgroundProcessingPool::threadFunction()
const auto name = "BkgPool" + std::to_string(tid++);
setThreadName(name.data());
is_background_thread = true;
addThreadId(gettid());
addThreadId(getTid());
}

MemoryTracker memory_tracker;
Expand Down