Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tiflash crash when setting join_concurrent_build = 0 #4735

Merged
merged 4 commits into from
Apr 24, 2022
Merged

fix tiflash crash when setting join_concurrent_build = 0 #4735

merged 4 commits into from
Apr 24, 2022

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Apr 22, 2022

What problem does this PR solve?

Issue Number: close #4734

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 22, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Lloyd-Pottiger
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 22, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 22, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Apr 22, 2022

Coverage for changed files

Filename                                                                                                               Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Flash/Coprocessor/DAGQueryBlockInterpreter.cpp         391               391     0.00%          46                46     0.00%         884               884     0.00%         312               312     0.00%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                                      391               391     0.00%          46                46     0.00%         884               884     0.00%         312               312     0.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17148      9495             44.63%    193118  96323        50.12%

full coverage report (for internal network access only)

@SeaRise SeaRise requested review from fzhedu and windtalker April 22, 2022 05:07
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 22, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 22, 2022

/run-integration-test

@SeaRise SeaRise requested a review from windtalker April 22, 2022 06:07
windtalker
windtalker approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 22, 2022
@SeaRise SeaRise requested a review from LittleFall April 22, 2022 07:27
Lloyd-Pottiger
Lloyd-Pottiger approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 22, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 22, 2022

/merge

@ti-chi-bot
Copy link
Member

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 22, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 22, 2022

/merge cancel

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 22, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Apr 22, 2022

Coverage for changed files

Filename                                           Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DataStreams/HashJoinBuildBlockInputStream.cpp            4                 4     0.00%           1                 1     0.00%           7                 7     0.00%           2                 2     0.00%
DataStreams/HashJoinBuildBlockInputStream.h              3                 3     0.00%           3                 3     0.00%           6                 6     0.00%           0                 0         -
Flash/Coprocessor/DAGQueryBlockInterpreter.cpp         406               387     4.68%          51                39    23.53%         933               851     8.79%         322               313     2.80%
Interpreters/Join.cpp                                 1276              1276     0.00%          79                79     0.00%        1411              1411     0.00%         856               856     0.00%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                 1689              1670     1.12%         134               122     8.96%        2357              2275     3.48%        1180              1171     0.76%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17250      9408             45.46%    194273  95790        50.69%

full coverage report (for internal network access only)

@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 24, 2022

/merge

@ti-chi-bot
Copy link
Member

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1b60956

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 24, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Apr 24, 2022

Coverage for changed files

Filename                                           Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DataStreams/HashJoinBuildBlockInputStream.cpp            4                 4     0.00%           1                 1     0.00%           7                 7     0.00%           2                 2     0.00%
DataStreams/HashJoinBuildBlockInputStream.h              3                 3     0.00%           3                 3     0.00%           6                 6     0.00%           0                 0         -
Flash/Coprocessor/DAGQueryBlockInterpreter.cpp         406               387     4.68%          51                39    23.53%         933               851     8.79%         322               313     2.80%
Interpreters/Join.cpp                                 1276              1276     0.00%          79                79     0.00%        1411              1411     0.00%         856               856     0.00%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                 1689              1670     1.12%         134               122     8.96%        2357              2275     3.48%        1180              1171     0.76%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17250      9408             45.46%    194273  95783        50.70%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 2d23426 into pingcap:master Apr 24, 2022
@SeaRise SeaRise deleted the fix_issue_4734 branch April 24, 2022 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@fzhedu fzhedu Awaiting requested review from fzhedu

@LittleFall LittleFall Awaiting requested review from LittleFall

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tiflash crash when setting join_concurrent_build = 0
5 participants
@SeaRise @ti-chi-bot @sre-bot @windtalker @Lloyd-Pottiger