Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fxied some compile errors on mac in PS V3 #4741

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Fxied some compile errors on mac in PS V3 #4741

merged 1 commit into from
Apr 25, 2022

Conversation

flowbehappy
Copy link
Contributor

@flowbehappy flowbehappy commented Apr 24, 2022 •
edited
Loading

Issue Number: close #4744

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 24, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JinheLin
  • jiaqizho

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@flowbehappy flowbehappy requested a review from jiaqizho April 24, 2022 05:21
@ti-chi-bot
Copy link
Member

@flowbehappy: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 24, 2022
@flowbehappy
Copy link
Contributor Author

/run-all-tests

jiaqizho
jiaqizho approved these changes Apr 24, 2022
View reviewed changes
Copy link
Contributor

@jiaqizho jiaqizho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 24, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Apr 24, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PageDirectory.cpp                 504                78    84.52%          31                 2    93.55%        1063               187    82.41%         394                94    76.14%
spacemap/SpaceMapSTDMap.h         153                19    87.58%          11                 0   100.00%         247                20    91.90%          96                20    79.17%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                             657                97    85.24%          42                 2    95.24%        1310               207    84.20%         490               114    76.73%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17250      9408             45.46%    194273  95788        50.69%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 24, 2022
@flowbehappy
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@flowbehappy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 621137c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 24, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Apr 24, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PageDirectory.cpp                 504                78    84.52%          31                 2    93.55%        1063               187    82.41%         394                94    76.14%
spacemap/SpaceMapSTDMap.h         153                19    87.58%          11                 0   100.00%         247                20    91.90%          96                20    79.17%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                             657                97    85.24%          42                 2    95.24%        1310               207    84.20%         490               114    76.73%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17250      9408             45.46%    194273  95784        50.70%

full coverage report (for internal network access only)

@flowbehappy flowbehappy removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-triage-completed labels Apr 24, 2022
@flowbehappy
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@flowbehappy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@flowbehappy flowbehappy self-assigned this Apr 24, 2022
@flowbehappy flowbehappy reopened this Apr 24, 2022
@flowbehappy
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@flowbehappy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Apr 24, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PageDirectory.cpp                 504                78    84.52%          31                 2    93.55%        1063               187    82.41%         394                94    76.14%
spacemap/SpaceMapSTDMap.h         153                19    87.58%          11                 0   100.00%         247                20    91.90%          96                20    79.17%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                             657                97    85.24%          42                 2    95.24%        1310               207    84.20%         490               114    76.73%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17250      9408             45.46%    194273  95795        50.69%

full coverage report (for internal network access only)

@flowbehappy
Copy link
Contributor Author

/build

@flowbehappy
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@flowbehappy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Apr 25, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PageDirectory.cpp                 504                78    84.52%          31                 2    93.55%        1063               187    82.41%         394                94    76.14%
spacemap/SpaceMapSTDMap.h         153                19    87.58%          11                 0   100.00%         247                20    91.90%          96                20    79.17%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                             657                97    85.24%          42                 2    95.24%        1310               207    84.20%         490               114    76.73%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17250      9408             45.46%    194273  95792        50.69%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit d752d0e into pingcap:master Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JinheLin JinheLin JinheLin approved these changes

@jiaqizho jiaqizho jiaqizho approved these changes

@JaySon-Huang JaySon-Huang Awaiting requested review from JaySon-Huang

Assignees

@flowbehappy flowbehappy

Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compile errors on mac in PS V3
5 participants
@flowbehappy @ti-chi-bot @sre-bot @JinheLin @jiaqizho