fix: Suppress the warning from boost to fix build failure.

[junaire]

Signed-off-by: Jun Zhang [email protected]

What problem does this PR solve?

Issue Number: close #4771

Problem Summary:

What is changed and how it works?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• JaySon-Huang
• fuzhe1989

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[junaire]

/cc @JaySon-Huang

[JaySon-Huang]

/merge

[ti-chi-bot]

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 34b9d4f

[sre-bot]

Coverage for changed files

Filename                                                                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Functions/GeoUtils.h         146               146     0.00%          34                34     0.00%         349               349     0.00%         110               110     0.00%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                            146               146     0.00%          34                34     0.00%         349               349     0.00%         110               110     0.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18053      10149            43.78%    200029  100941       49.54%

full coverage report (for internal network access only)

[jiaqizho]

@JaySon-Huang @fuzhe1989 Can't build-in clang.

/dbms/src/Functions/GeoUtils.h:33:32: error: unknown warning group '-Wunused-but-set-variable', ignored [-Werror,-Wunknown-warning-option]
#pragma GCC diagnostic ignored "-Wunused-but-set-variable"
                               ^

[junaire]

@JaySon-Huang @fuzhe1989 Can't build-in clang.

/dbms/src/Functions/GeoUtils.h:33:32: error: unknown warning group '-Wunused-but-set-variable', ignored [-Werror,-Wunknown-warning-option]
#pragma GCC diagnostic ignored "-Wunused-but-set-variable"
                               ^

May I ask your clang version? For me everything works fine for Clang trunk.
In fact, this flag is recently added in https://reviews.llvm.org/D100581, and I was surprised they don't even provide a release note...

[JaySon-Huang]

@JaySon-Huang @fuzhe1989 Can't build-in clang.

/dbms/src/Functions/GeoUtils.h:33:32: error: unknown warning group '-Wunused-but-set-variable', ignored [-Werror,-Wunknown-warning-option]
#pragma GCC diagnostic ignored "-Wunused-but-set-variable"
                               ^

@jiaqizho What's your error message for compile error? The CI build TiFlash with Clang 13.0.0 and give no warnings/errors https://ci.pingcap.net/blue/organizations/jenkins/tiflash-build-common/detail/tiflash-build-common/4096/pipeline/150

[junaire]

I just realized that the minimal toolchain requirement were not matched in the CMakelists.txt and README. That said cmake will only complain when clang < 5 or gcc < 7. I guess that will confuse some folks especially who first work on the project. If we really just want guarantee tiflash compiles in recent compilers, maybe we should align the requirements in CMakelists.txt @JaySon-Huang @fuzhe1989 @ywqzzy

[JaySon-Huang]

Now we only declare the minimal toolchain requirement in the README.md (and collapsed by default). We have not changed the related warnings in CMakeLists.txt yet.

/cc @SchrodingerZhu

[jiaqizho]

@JaySon-Huang @fuzhe1989 Can't build-in clang.

/dbms/src/Functions/GeoUtils.h:33:32: error: unknown warning group '-Wunused-but-set-variable', ignored [-Werror,-Wunknown-warning-option]
#pragma GCC diagnostic ignored "-Wunused-but-set-variable"
                               ^

@jiaqizho What's your error message for compile error? The CI build TiFlash with Clang 13.0.0 and give no warnings/errors https://ci.pingcap.net/blue/organizations/jenkins/tiflash-build-common/detail/tiflash-build-common/4096/pipeline/150

Apple clang version 12.0.5 (clang-1205.0.22.11)

[junaire]

@JaySon-Huang @fuzhe1989 Can't build-in clang.

/dbms/src/Functions/GeoUtils.h:33:32: error: unknown warning group '-Wunused-but-set-variable', ignored [-Werror,-Wunknown-warning-option]
#pragma GCC diagnostic ignored "-Wunused-but-set-variable"
                               ^

@jiaqizho What's your error message for compile error? The CI build TiFlash with Clang 13.0.0 and give no warnings/errors https://ci.pingcap.net/blue/organizations/jenkins/tiflash-build-common/detail/tiflash-build-common/4096/pipeline/150

Apple clang version 12.0.5 (clang-1205.0.22.11)

Good, that's the issue I guess. I don't have a mac so I can't really test it, but the following godbolt link shows that this flag is only supported after clang 13: https://godbolt.org/z/hWr5bss85 Maybe try to use homebrew to get yourself a more recent compiler?

[JaySon-Huang]

We can add a line #pragma GCC diagnostic ignored "-Wunknown-warning-option" before "-Wunused-but-set-variable" to make it compatible with older clang https://github.com/pingcap/tiflash/pull/4784/files