Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not moving local object in return statement #4815

Merged
merged 2 commits into from
May 5, 2022
Merged

Not moving local object in return statement #4815

merged 2 commits into from
May 5, 2022

Conversation

ehds
Copy link
Contributor

@ehds ehds commented Apr 30, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #4824

Problem Summary:
Moving a local object in a return statement prevents copy elision.

What is changed and how it works?

Compilers are allowed to automatically move the return value (to optimize out the copy), and even optimize out the move!

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 30, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fuzhe1989
  • ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Apr 30, 2022
@CLAassistant
Copy link

CLAassistant commented Apr 30, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot
Copy link
Member

Welcome @ehds!

It looks like this is your first PR to pingcap/tiflash 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tiflash. 😃

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 30, 2022
@fuzhe1989
Copy link
Contributor

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented May 5, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DynamicThreadPool.h                 3                 1    66.67%           3                 1    66.67%          13                 4    69.23%           0                 0         -
packTask.h                          1                 0   100.00%           1                 0   100.00%           7                 0   100.00%           0                 0         -
wrapInvocable.h                     4                 0   100.00%           2                 0   100.00%          17                 0   100.00%           2                 0   100.00%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                               8                 1    87.50%           6                 1    83.33%          37                 4    89.19%           2                 0   100.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18053      10149            43.78%    200029  100919       49.55%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 5, 2022
@fuzhe1989 fuzhe1989 requested a review from ywqzzy May 5, 2022 02:58
ywqzzy
ywqzzy approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@ywqzzy ywqzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 5, 2022
@fuzhe1989
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@fuzhe1989: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3e6fa97

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 5, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented May 5, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DynamicThreadPool.h                 3                 1    66.67%           3                 1    66.67%          13                 4    69.23%           0                 0         -
packTask.h                          1                 0   100.00%           1                 0   100.00%           7                 0   100.00%           0                 0         -
wrapInvocable.h                     4                 0   100.00%           2                 0   100.00%          17                 0   100.00%           2                 0   100.00%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                               8                 1    87.50%           6                 1    83.33%          37                 4    89.19%           2                 0   100.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18053      10149            43.78%    200029  100930       49.54%

full coverage report (for internal network access only)

@sre-bot
Copy link
Collaborator

sre-bot commented May 5, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DynamicThreadPool.h                 3                 1    66.67%           3                 1    66.67%          13                 4    69.23%           0                 0         -
packTask.h                          1                 0   100.00%           1                 0   100.00%           7                 0   100.00%           0                 0         -
wrapInvocable.h                     4                 0   100.00%           2                 0   100.00%          17                 0   100.00%           2                 0   100.00%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                               8                 1    87.50%           6                 1    83.33%          37                 4    89.19%           2                 0   100.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18066      10143            43.86%    200443  100957       49.63%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 702b7d1 into pingcap:master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuzhe1989 fuzhe1989 fuzhe1989 approved these changes

@ywqzzy ywqzzy ywqzzy approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not moving local object in return statement
6 participants
@ehds @ti-chi-bot @CLAassistant @fuzhe1989 @sre-bot @ywqzzy