Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server: reduce too many pings #5528

Merged
merged 3 commits into from
Sep 23, 2022
Merged

Server: reduce too many pings #5528

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e9db473
Server: reduce too many pings
jackysp Aug 3, 2022
f178797
Merge branch 'master' into fix_many_pings
windtalker Sep 22, 2022
adfb06d
Merge branch 'master' into fix_many_pings
ti-chi-bot Sep 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion dbms/src/Server/FlashGrpcServerHolder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ FlashGrpcServerHolder::FlashGrpcServerHolder(Context & context, Poco::Util::Laye
diagnostics_service = std::make_unique<DiagnosticsService>(context, config_);
builder.SetOption(grpc::MakeChannelArgumentOption(GRPC_ARG_HTTP2_MIN_RECV_PING_INTERVAL_WITHOUT_DATA_MS, 5 * 1000));
builder.SetOption(grpc::MakeChannelArgumentOption(GRPC_ARG_HTTP2_MIN_SENT_PING_INTERVAL_WITHOUT_DATA_MS, 10 * 1000));
builder.SetOption(grpc::MakeChannelArgumentOption(GRPC_ARG_KEEPALIVE_PERMIT_WITHOUT_CALLS, 1));
// number of grpc thread pool's non-temporary threads, better tune it up to avoid frequent creation/destruction of threads
auto max_grpc_pollers = context.getSettingsRef().max_grpc_pollers;
if (max_grpc_pollers > 0 && max_grpc_pollers <= std::numeric_limits<int>::max())
Expand Down