Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: remove array functions. #5987

Merged
merged 3 commits into from
Sep 22, 2022
Merged

*: remove array functions. #5987

merged 3 commits into from
Sep 22, 2022

Conversation

ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Sep 22, 2022

What problem does this PR solve?

Issue Number: ref #4640

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 22, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SeaRise
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 22, 2022
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Sep 22, 2022

/run-all-tests

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Sep 22, 2022

/rebuild

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Sep 22, 2022

/run-all-tests

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Sep 22, 2022

/run-unit-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Sep 22, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FunctionsConditional.cpp           76                13    82.89%           9                 1    88.89%         176                25    85.80%          52                17    67.31%
FunctionsConditional.h            501               498     0.60%          33                30     9.09%         648               645     0.46%         368               368     0.00%
FunctionsString.cpp              1537               383    75.08%         290                73    74.83%        3336               799    76.05%         954               313    67.19%
FunctionsTiDBConversion.h         815               388    52.39%          85                19    77.65%        1857               530    71.46%         468               291    37.82%
FunctionsURL.cpp                   30                29     3.33%           6                 5    16.67%          95                75    21.05%          18                18     0.00%
FunctionsURL.h                    248               248     0.00%          27                27     0.00%         385               385     0.00%         172               172     0.00%
registerFunctions.cpp               1                 0   100.00%           1                 0   100.00%          30                 0   100.00%           0                 0         -
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                            3208              1559    51.40%         451               155    65.63%        6527              2459    62.33%        2032              1179    41.98%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18330      7576             58.67%    214297  77850        63.67%

full coverage report (for internal network access only)

@sre-bot
Copy link
Collaborator

sre-bot commented Sep 22, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FunctionsConditional.cpp           76                13    82.89%           9                 1    88.89%         176                25    85.80%          52                17    67.31%
FunctionsConditional.h            501               498     0.60%          33                30     9.09%         648               645     0.46%         368               368     0.00%
FunctionsString.cpp              1537               384    75.02%         290                73    74.83%        3336               801    75.99%         954               314    67.09%
FunctionsTiDBConversion.h         815               386    52.64%          85                19    77.65%        1857               526    71.67%         468               289    38.25%
FunctionsURL.cpp                   30                29     3.33%           6                 5    16.67%          95                75    21.05%          18                18     0.00%
FunctionsURL.h                    248               248     0.00%          27                27     0.00%         385               385     0.00%         172               172     0.00%
registerFunctions.cpp               1                 0   100.00%           1                 0   100.00%          30                 0   100.00%           0                 0         -
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                            3208              1558    51.43%         451               155    65.63%        6527              2457    62.36%        2032              1178    42.03%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18258      7506             58.89%    213634  77209        63.86%

full coverage report (for internal network access only)

@ywqzzy ywqzzy marked this pull request as ready for review September 22, 2022 05:12
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 22, 2022
SeaRise
SeaRise approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 22, 2022
windtalker
windtalker approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 22, 2022
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Sep 22, 2022

/merge

@ti-chi-bot
Copy link
Member

@ywqzzy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1c3c1bb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 22, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Sep 22, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FunctionsConditional.cpp           76                13    82.89%           9                 1    88.89%         176                25    85.80%          52                17    67.31%
FunctionsConditional.h            501               498     0.60%          33                30     9.09%         648               645     0.46%         368               368     0.00%
FunctionsString.cpp              1537               383    75.08%         290                73    74.83%        3336               799    76.05%         954               313    67.19%
FunctionsTiDBConversion.h         815               392    51.90%          85                19    77.65%        1857               530    71.46%         468               292    37.61%
FunctionsURL.cpp                   30                29     3.33%           6                 5    16.67%          95                75    21.05%          18                18     0.00%
FunctionsURL.h                    248               248     0.00%          27                27     0.00%         385               385     0.00%         172               172     0.00%
registerFunctions.cpp               1                 0   100.00%           1                 0   100.00%          30                 0   100.00%           0                 0         -
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                            3208              1563    51.28%         451               155    65.63%        6527              2459    62.33%        2032              1180    41.93%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18259      7510             58.87%    213598  77201        63.86%

full coverage report (for internal network access only)

@sre-bot
Copy link
Collaborator

sre-bot commented Sep 22, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FunctionsConditional.cpp           76                13    82.89%           9                 1    88.89%         176                25    85.80%          52                17    67.31%
FunctionsConditional.h            501               498     0.60%          33                30     9.09%         648               645     0.46%         368               368     0.00%
FunctionsString.cpp              1537               383    75.08%         290                73    74.83%        3336               799    76.05%         954               313    67.19%
FunctionsTiDBConversion.h         815               386    52.64%          85                19    77.65%        1857               526    71.67%         468               287    38.68%
FunctionsURL.cpp                   30                29     3.33%           6                 5    16.67%          95                75    21.05%          18                18     0.00%
FunctionsURL.h                    248               248     0.00%          27                27     0.00%         385               385     0.00%         172               172     0.00%
registerFunctions.cpp               1                 0   100.00%           1                 0   100.00%          30                 0   100.00%           0                 0         -
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                            3208              1557    51.47%         451               155    65.63%        6527              2455    62.39%        2032              1175    42.18%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18259      7511             58.86%    213598  77173        63.87%

full coverage report (for internal network access only)

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Sep 22, 2022

/run-integration-tests

@ti-chi-bot ti-chi-bot merged commit ad41d9d into pingcap:master Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@SeaRise SeaRise SeaRise approved these changes

@fuzhe1989 fuzhe1989 Awaiting requested review from fuzhe1989

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ywqzzy @ti-chi-bot @sre-bot @windtalker @SeaRise