-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: Bind delta merge storage with executor ut #6561
Test: Bind delta merge storage with executor ut #6561
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
/run-all-tests |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others lgtm
|
||
BlockInputStreamPtr MockStorage::getStreamFromDeltaMerge(Context & context, Int64 id) | ||
{ | ||
auto storage = storage_delta_merge_map[id]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add some assert for function xxxFromDeltaMerge
/cc @JaySon-Huang |
/run-unit-test |
/run-unit-tests |
/run-unit-tests |
/run-all-tests |
/run-all-tests |
434b53a
to
59fd171
Compare
/merge |
@ywqzzy: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: b67b85a
|
What problem does this PR solve?
Issue Number: ref #4609
Problem Summary:
We want to use
DeltaMergeStorage
to run the query inut framework
.Then we can test the whole query process in single node(not including mpp with multiple nodes, we assume that data are stored in one node).
It will be helpful for features that change both
storage code
andcompute code
. Eg: late materialization and pipeline model.Maybe RSFilter can use
ut framework
too.Here is one simple case:
What is changed and how it works?
MockStorage
to holdDeltaMergeStorage
.to define the table schema and insert table columns.
3.
addMockDeltaMerge
will callto add schema and data into corresponding
DeltaMergeStorage
4. When running a test query, planner will choose to use the
DeltaMergeStorage
to generate source streams.5. BTW, I have moved a bunch of code like
into
dbms/src/TestUtils/ExecutorTestUtils.h
to make the test code cleaner.Check List
Tests
Side effects
Documentation
Release note