Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support collation in group by and join operator #771

Merged
merged 12 commits into from
Jul 7, 2020
Merged

support collation in group by and join operator #771

merged 12 commits into from
Jul 7, 2020

Conversation

windtalker
Copy link
Contributor

  • introduce collation in aggregation/join input stream
  • refine getKey related code in SetVariants

@windtalker windtalker requested a review from zanmato1984 June 9, 2020 08:20
@windtalker windtalker added the needs-cherry-pick-release-4.0 PR which needs to be cherry-picked to release-4.0 label Jun 9, 2020
@windtalker
Copy link
Contributor Author

/run-integration-tests

@zanmato1984 zanmato1984 added the type/enhancement The issue or PR belongs to an enhancement. label Jul 1, 2020
zanmato1984
zanmato1984 approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@windtalker
Copy link
Contributor Author

/run-all-tests

@windtalker windtalker merged commit 84c2650 into pingcap:master Jul 7, 2020
@windtalker windtalker deleted the collation_agg_join branch July 7, 2020 04:33
@ti-srebot
Copy link
Collaborator

cherry pick to release-4.0 failed

@windtalker windtalker mentioned this pull request Jul 7, 2020
Merged
windtalker added a commit that referenced this pull request Jul 8, 2020
@windtalker
support collation in group by and join operator (#771) (#885)
1ab4fd9 
* support collation in agg

* support collation in hash method based agg/set

* support collation in join

* fix bug

* refine

* refine

* refine

* support join with new collators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanmato1984 zanmato1984 zanmato1984 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-4.0 PR which needs to be cherry-picked to release-4.0 type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@windtalker @ti-srebot @zanmato1984