Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust the soft limit of mintso scheduler to logical cores #8156

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Adjust the soft limit of mintso scheduler to logical cores #8156

merged 1 commit into from
Sep 28, 2023

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Sep 28, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #8157

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue labels Sep 28, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Sep 28, 2023

/cc @windtalker @yibin87 @Lloyd-Pottiger

@SeaRise
Copy link
Contributor Author

SeaRise commented Sep 28, 2023

/check-issue-triage-complete

@SeaRise
Copy link
Contributor Author

SeaRise commented Sep 28, 2023

/run-all-tests

windtalker
windtalker approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 28, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 28, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Lloyd-Pottiger, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Lloyd-Pottiger,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-28 03:02:21.118744722 +0000 UTC m=+70938.705854851: ☑️ agreed by windtalker.
  • 2023-09-28 07:51:08.033122491 +0000 UTC m=+88265.620232637: ☑️ agreed by Lloyd-Pottiger.

@ti-chi-bot ti-chi-bot bot merged commit 6918946 into pingcap:master Sep 28, 2023
@SeaRise SeaRise deleted the adjust_soft_limit branch September 28, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@windtalker windtalker windtalker approved these changes

@yibin87 yibin87 Awaiting requested review from yibin87

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The soft limit of MintSO scheduler is too small.
3 participants
@SeaRise @windtalker @Lloyd-Pottiger