-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the compatibility issue in func FunctionIPv4NumToString
#8210
Conversation
Signed-off-by: Zhigao Tong <[email protected]>
FunctionIPv4NumToString
supports integer data type(size <= 4 bytes)
Signed-off-by: Zhigao Tong <[email protected]>
e27b93a
to
0f3ebb5
Compare
/cc @windtalker |
Signed-off-by: TONG, Zhigao <[email protected]>
Signed-off-by: Zhigao Tong <[email protected]>
Signed-off-by: Zhigao Tong <[email protected]>
Signed-off-by: Zhigao Tong <[email protected]>
Signed-off-by: Zhigao Tong <[email protected]>
FunctionIPv4NumToString
supports integer data type(size <= 4 bytes)FunctionIPv4NumToString
supports unsigned integer (size <= 4 bytes)
Signed-off-by: Zhigao Tong <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[LGTM Timeline notifier]Timeline:
|
/approve |
@solotzg: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guo-shaoge, solotzg, windtalker, yibin87 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/run-integration-test |
/cherry-pick release-7.5 |
@solotzg: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/cherry-pick release-7.1 |
/cherry-pick release-6.5 |
@solotzg: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <[email protected]>
@solotzg: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <[email protected]>
What problem does this PR solve?
Issue Number: close #8211
Problem Summary:
FunctionIPv4NumToString
only supports argument whose type isUInt32
.What is changed and how it works?
FunctionIPv4NumToString
support unsigned integer data type.Out of range
). Under MPP mode, TiFlash will omit warning.?
.?
.?
' for function inet_ntoaCheck List
Tests
Side effects
Documentation
Release note