Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storages: disaggregated mode supports storage read thread. #8272

Merged
merged 15 commits into from
Nov 4, 2023
Merged

Storages: disaggregated mode supports storage read thread. #8272

merged 15 commits into from
Nov 4, 2023

Conversation

JinheLin
Copy link
Contributor

@JinheLin JinheLin commented Oct 30, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #6834

What is changed and how it works?

  • Refine RNWorkerFetchPages and RNWorkerPrepareStreams，encapsulate the functions into SegmentReadTask for reuse.
  • The read thread pool supports disaggregated mode.
  • Add some unittests.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 30, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 30, 2023
@JinheLin JinheLin force-pushed the support-scheduler branch 7 times, most recently from 1c7ac3e to 77e8f79 Compare November 1, 2023 10:38
@JinheLin
Copy link
Contributor Author

JinheLin commented Nov 1, 2023

/run-all-tests

@JinheLin JinheLin changed the title WIP: Support scheduler Storages: disaggregated mode supports storage read thread. Nov 2, 2023
@JinheLin JinheLin marked this pull request as ready for review November 2, 2023 02:13
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 2, 2023
@JinheLin
Copy link
Contributor Author

JinheLin commented Nov 2, 2023

/run-all-tests

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 2, 2023
@JinheLin
Copy link
Contributor Author

JinheLin commented Nov 3, 2023

/run-all-tests

@JinheLin JinheLin requested a review from JaySon-Huang November 3, 2023 08:27
@JaySon-Huang
Copy link
Contributor

Suggest some changes here: JinheLin#1

@JinheLin
Copy link
Contributor Author

JinheLin commented Nov 3, 2023

/run-all-tests

@JinheLin JinheLin requested a review from JaySon-Huang November 3, 2023 11:08
@JinheLin
Copy link
Contributor Author

JinheLin commented Nov 3, 2023

/run-integration-test

1 similar comment
@JinheLin
Copy link
Contributor Author

JinheLin commented Nov 3, 2023

/run-integration-test

JaySon-Huang
JaySon-Huang approved these changes Nov 4, 2023
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 4, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 4, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 4, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-02 09:07:48.891825021 +0000 UTC m=+3116866.478935151: ☑️ agreed by Lloyd-Pottiger.
  • 2023-11-04 01:43:13.21861453 +0000 UTC m=+3262990.805724673: ☑️ agreed by JaySon-Huang.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 4, 2023

@JinheLin: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit cfe64ce into pingcap:master Nov 4, 2023
@JaySon-Huang JaySon-Huang mentioned this pull request Nov 6, 2023
Closed
@JaySon-Huang JaySon-Huang mentioned this pull request Dec 7, 2023
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@CalvinNeo CalvinNeo Awaiting requested review from CalvinNeo

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JinheLin @JaySon-Huang @Lloyd-Pottiger